Floating point casting machinery #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was previously testing the values before casting, but we're really interested in the results after casting. longdouble test now also works at least on this Intel system.
Trying to avoid import-time use of np.finfo because of warnings in the code that this will increase import time.
Flag to force integer values to maximum and minimum of the integer dtype.
Scalar nan gave an error for fancy indexing.
floating, casting into one file. When testing for int_clippers and casting, allow for possibility that the overflow generates the integer maximum / minimum rather than a very negative value (in the max overflow case)
|
Any comments here? |
|
Will merge tomorrow unless I hear otherwise |
matthew-brett
added a commit
that referenced
this pull request
Nov 12, 2011
Floating point casting machinery Routines for robust casting of floating point to integer, checking for overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routines for robust casting of floating point to integer, checking for overflow.
I'm planning to use these in the array_to_file saving of floating point arrays to images.