DOC: update release docs to use try_branch.py
#386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove some emphasis on outdated check scripts.
matthew-brett
force-pushed
the
update-release-list
branch
from
8b4c882 to
ed40f34
Compare
|
|
||
| If you are already on a Windows machine, you could have done the manual | ||
| command to build instead: ``python setup.py bdist_wininst``. | ||
|
|
There was a problem hiding this comment.
I feel like this makes sense to move to below the release commit, otherwise you end up with x.y.z.dev binaries. I ended up doing this sequence:
- Update docs and
nibabel/info.pyon a PR branch - Merge PR in Github
- Pull
maint/2.0.x, tag and push tag - Push to pypi
- Push to buildbots
There was a problem hiding this comment.
Ah yes, you're right. But I personally like to avoid pushing the tag for as long as possible because it can't be reversed after. So I suggest try_branch pushing to the buildbots after the release commit, but before pushing the release commit or the release tag.
There was a problem hiding this comment.
I checked the builds on the branch that had been merged in before tagging, but that's a good policy.
Add an introduction to the release procedure.
matthew-brett
force-pushed
the
update-release-list
branch
from
b066c9b to
b09926c
Compare
These are working for nibabel, but not when we need a compiler.
|
OK to merge this one? |
|
LGTM |
matthew-brett
added a commit
that referenced
this pull request
Nov 29, 2015
DOC: update release docs to use `try_branch.py` Also, remove some emphasis on outdated check scripts.
|
Thanks - merging. |
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
DOC: update release docs to use `try_branch.py` Also, remove some emphasis on outdated check scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove some emphasis on outdated check scripts.