TEST: Nifti test bug; STY: PEP8 test_nifti1 #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ((2, minf), HDE, HDE, (2, minf))): | ||
| # Good slope and inter - you guessed it | ||
| ((2, 0), None, (None, None), (2, 0)), | ||
| ((2, 1), None, (None, None), (2, 1)), |
There was a problem hiding this comment.
The colon/comma swap was the bug. Last two conditions weren't iterated over but were unassigned values in the loop body.
Updated the values in the unrun tests to not fail, but this should be checked for validity.
|
LGTM |
|
Okay. Slightly modified your inline comment to fit in 79 characters, and moved the |
effigies
force-pushed
the
nifti_test_bug
branch
from
f59cfaa to
8f15523
Compare
|
Anything left to do on this one? |
|
Thanks for the reminder - and the rewrite. |
matthew-brett
added a commit
that referenced
this pull request
Sep 3, 2015
MRG: Nifti test bug; STY: PEP8 test_nifti1 PEP8 refactoring; restoring a couple of tests accidentally chopped. Improving one test.
Closed
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: Nifti test bug; STY: PEP8 test_nifti1 PEP8 refactoring; restoring a couple of tests accidentally chopped. Improving one test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing tests on #332 PEP8, I cleaned the file and ran into a bug.
One outstanding PEP8 issue because I couldn't parse a comment enough to reword.