STY: PEP8/PyFlakes #337
STY: PEP8/PyFlakes #337
Conversation
| # and then give up. At this stage we're expecting exotic longdouble or their | ||
| # complex equivalent. | ||
| # and then give up. At this stage we're expecting exotic longdouble or | ||
| # their complex equivalent. |
| @@ -561,7 +564,8 @@ def optimize_read_slicers(sliceobj, in_shape, itemsize, heuristic): | |||
|
|
|||
|
|
|||
| def slicers2segments(read_slicers, in_shape, offset, itemsize): | |||
| """ Get segments from `read_slicers` given input `in_shape` and memory steps | |||
| """ Get segments from `read_slicers` given input `in_shape` and memory | |||
There was a problem hiding this comment.
Should be one line to match match numpy docstring standard.
Maybe Get segments fromread_slicersgivenin_shapeand memory steps ?
|
Left as new commits so you can see the changes. Will rebase into original 3 when it's ready to go. |
| @@ -1345,7 +1346,8 @@ def _ftype4scaled_finite(tst_arr, slope, inter, direction='read', | |||
|
|
|||
|
|
|||
| def finite_range(arr, check_nan=False): | |||
| ''' Return range (min, max) or range and flag (min, max, has_nan) from `arr` | |||
| ''' Return range (min, max) or range and flag (min, max, has_nan) from | |||
There was a problem hiding this comment.
Should be on single line for numpy docstring standard. Maybe Get range (min, max) or range and flag (min, max, has_nan) from arr``
|
Thanks for doing this. I sense a lots of rebases in the air... |
|
Thanks for this - ready to go - squash and merge when ready. |
|
Rebased against master and tests run clean locally. |
MRG: PEP8/PyFlakes Big PEP8 clean up, let's hope we don't have to another one of these for a while.
|
Thanks for this - very helpful. |
|
Ugh. Just noticed a typo (s/intO/into/). Probably not worth another PR if you just want to drop a quick commit. |
|
Thanks - fixed I think. |
MRG: PEP8/PyFlakes Big PEP8 clean up, let's hope we don't have to another one of these for a while.
This is a fairly comprehensive style cleanup to meet PEP8 and pyflakes suggestions throughout the non-test code. Tests pass locally, but submitting for CI testing.
Almost all changes are spacing issues. There are a couple variables that are removed when being assigned to values or functions known not to have side effects. Not all suggestions were incorporated, particularly when a style seemed to be intentional and consistent.