-
Notifications
You must be signed in to change notification settings - Fork 262
TEST: Only use stable argsorts in PARREC tests #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 98 98
Lines 12364 12364
Branches 2539 2539
=======================================
Hits 11395 11395
Misses 646 646
Partials 323 323 ☔ View full report in Codecov by Sentry. |
Okay. So it is Numpy 1.25. Still unclear why it's 100% of the time here and I've been unable to reproduce even stochastically on my local machine. |
Looking through the commit logs between the last succeeding and first failing pre-releases: numpy/numpy@126b46c...v1.25.0 I think numpy/numpy#23707 is a likely candidate. Will try finding alternatives to argsort for the failing tests. |
@grlee77 Would you mind having a look? |
Bug report here: numpy/numpy#24064 We'll see if we need to include this patch or if we should just tolerate failures until numpy releases a fix. |
Nevermind. This was our fault for not explicitly requesting a stable argsort. Merging. |
numpy/numpy#23707 introduced an optimized argsort that will be used on some platforms, including GitHub actions' runners, making this a nasty issue to figure out. I'm very glad that it wasn't on some obscure architecture that one user hit, as I have no idea how I would have debugged that.
Between the last good and first bad runs, numpy released 1.25 and GitHub Actions released new Python images. First starting by verifying that the previous versions of both resolve the issue. Then will relax numpy.