[ENH] Use indexed_gzip with nibabel #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements this suggestion nipreps#766 (comment) If we find this useful, it is worth considering to add a new nipype config that leverages indexed_gzip with nibabel. Hopefully, this is the last piece of several PRs to fix nipreps#766
effigies
reviewed
Oct 25, 2017
fmriprep/cli/run.py
Outdated
| import nibabel | ||
| nibabel.arrayproxy.KEEP_FILE_OPEN_DEFAULT = 'auto' | ||
| except ImportError: | ||
| pass |
There was a problem hiding this comment.
You can just do nibabel.arrayproxy.KEEP_FILE_OPEN_DEFAULT = 'auto', without checking imports. All that does is set the default to "use indexed_gzip if available, otherwise don't change behavior".
fmriprep/info.py
Outdated
| @@ -71,6 +71,7 @@ | |||
| 'statsmodels', | |||
| 'nipype', | |||
| 'seaborn', | |||
| 'indexed_gzip', | |||
There was a problem hiding this comment.
indexed_gzip>=0.6.1
You can get a slowdown on some operations with 0.6.0 or earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements this suggestion #766 (comment)
If we find this useful, it is worth considering to add a new nipype config that leverages indexed_gzip with nibabel.
Hopefully, this is the last piece of several PRs to fix #766