fix: redirect named splat filesystem routes correctly for SSR/DSG pages #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
approved these changes
Apr 22, 2022
ericapisani
reviewed
Apr 26, 2022
There was a problem hiding this comment.
This looks great!
If you have the time, adding test coverage on this would be stellar. (edit: just noticing Matt's initial review above and am +1-ing it)
There's an existing test that focuses on the SSR/DSG redirects functionality that could be used as a helpful resource.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin redirects SSR/DSG pages to the relevant handler function, but was failing for SSR/DSG pages using filesystem routing named splats, because the param name was being incorrectly output in the fromPath of the redirect.
This PR ensures that redirects contains only the splat and the named param is only forwarded to the handler function.
In addition, this PR ensures that SSG client-only routes aren't also erroneously output alongside SSR/DSG redirects when using file system routing.