-
-
Notifications
You must be signed in to change notification settings - Fork 448
Add support for Windows arm64 #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, but do we need to add the new architecture to workflows other than kits.yml? I don't test on more than one architecture for the other operating systems. BTW, kits.yml is computed, and I need to add a check that should have failed for this pull request. My bad. |
Oh maybe not, I didn't look closely enough to see that. I can remove the changes to coverage and test then! As for kit.yml, I did run it manually on my fork at least, the results are here. |
I've reverted my changes in both |
Oops, I don't know what I thought you said but I totally misread this the first time. What do you mean by kits is computed? Is there a script that generates |
Thanks. Do you mind rebasing on top of master? I tweaked the CI checks. |
Sure! |
I could probably make it clearer what failed here, but I'm interested in hearing what you make of it. |
I was just trying to figure that out 😄. It looks like maybe the matrix options in kit.yml are generated from the comment just above using Is that why it is failing? |
Yes, exactly. I think I can add a comment just below the checksum line that explains all that. The matrix is computed, and should be changed by editing the Python code in the comment, not by editing the actual matrix. |
Thanks! I think I did it the right way this time. |
This is also making me realize we should build the kits any time kits.yml changes! |
Yeah, I did start a run manually on my fork again though! |
Thanks, I'll update the contributors list and changelog in the next commit. |
Awesome, thanks again for taking the time to walk me through all that @nedbat ! |
Thanks for keeping me ignorant of Powershell! :D |
This is now released as part of coverage 7.8.2. |
Closes #1971
This would add builds for arm64 windows wheels to
kit.yml
for use in the publish workflow, as well as add windows arm64 to the test and coverage workflows.