Skip to content

Add support for Windows arm64 #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2025
Merged

Add support for Windows arm64 #1972

merged 16 commits into from
May 22, 2025

Conversation

finnagin
Copy link
Contributor

Closes #1971

This would add builds for arm64 windows wheels to kit.yml for use in the publish workflow, as well as add windows arm64 to the test and coverage workflows.

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

Thanks, but do we need to add the new architecture to workflows other than kits.yml? I don't test on more than one architecture for the other operating systems.

BTW, kits.yml is computed, and I need to add a check that should have failed for this pull request. My bad.

@finnagin
Copy link
Contributor Author

Oh maybe not, I didn't look closely enough to see that. I can remove the changes to coverage and test then!

As for kit.yml, I did run it manually on my fork at least, the results are here.

@finnagin
Copy link
Contributor Author

I've reverted my changes in both coverage.yml and testsuite.yml.

@finnagin
Copy link
Contributor Author

BTW, kits.yml is computed, and I need to add a check that should have failed for this pull request. My bad.

Oops, I don't know what I thought you said but I totally misread this the first time. What do you mean by kits is computed? Is there a script that generates kit.yml?

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

Thanks. Do you mind rebasing on top of master? I tweaked the CI checks.

@finnagin
Copy link
Contributor Author

Thanks. Do you mind rebasing on top of master? I tweaked the CI checks.

Sure!

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

I could probably make it clearer what failed here, but I'm interested in hearing what you make of it.

@finnagin
Copy link
Contributor Author

finnagin commented May 22, 2025

I could probably make it clearer what failed here, but I'm interested in hearing what you make of it.

I was just trying to figure that out 😄. It looks like maybe the matrix options in kit.yml are generated from the comment just above using cogapp and the fact that I manually added the martix options for arm64 windows caused it to fail when it checked the checksum of my kit.yml to the output of cogapp.

Is that why it is failing?

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

Is that why it is failing?

Yes, exactly. I think I can add a comment just below the checksum line that explains all that. The matrix is computed, and should be changed by editing the Python code in the comment, not by editing the actual matrix.

@finnagin
Copy link
Contributor Author

Yes, exactly. I think I can add a comment just below the checksum line that explains all that. The matrix is computed, and should be changed by editing the Python code in the comment, not by editing the actual matrix.

Thanks! I think I did it the right way this time.

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

This is also making me realize we should build the kits any time kits.yml changes!

@finnagin
Copy link
Contributor Author

Yeah, I did start a run manually on my fork again though!

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

Thanks, I'll update the contributors list and changelog in the next commit.

@nedbat nedbat merged commit a608fb3 into nedbat:master May 22, 2025
14 checks passed
@finnagin
Copy link
Contributor Author

Awesome, thanks again for taking the time to walk me through all that @nedbat !

@nedbat
Copy link
Owner

nedbat commented May 22, 2025

Thanks for keeping me ignorant of Powershell! :D

@finnagin finnagin deleted the arm64-runner branch May 22, 2025 23:39
@nedbat
Copy link
Owner

nedbat commented May 23, 2025

This is now released as part of coverage 7.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Winodws arm64 wheels
2 participants