Skip to content

fix_ios_serviceUUID_assigned_numbers #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

two-bridges
Copy link
Contributor

Fix to handle Short UUID and Long UUID... In case the hardware platform returns a Long UUID when we were expecting a Short UUID.

Note Short UUIDs are usually expected when the Service UUID is an Bluetooth Assigned Name...

For some reason (whether due to arduino BLE programming; or, iPhone version) the Assigne Name service UUID was being presented in Long UUID format, whereas BLE plugin was assuming it should be Short UUID.

This change will cause BLE to support Assigned Names as Long or Short UUIDs (regardless of how the platform returns them)

@farfromrefug
Copy link
Member

@two-bridges thanks a lot for this PR. Vert clean and detailed!

@farfromrefug farfromrefug merged commit f71573b into nativescript-community:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants