[Fix - build error]Set the working version of Gemma.cpp Git tag #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pagakarthik
commented
Mar 15, 2024
•
pagakarthik
commented
- since the dependencies are managed within Cmake , remove gitmodules - makes the repo simple
- the master branch fails when using the latest commit in the parent Gemma.cpp origin/main, this is because of the updated libgemma interface. This PR sets the Gemma.cpp git tag to the first commit.
- Note to the maintainer: please consider updating the commit hash to a working version that you might have locally.
- The actual fix would be update the bindings to support the latest libgemma interface. This commit is intended to support the current version.
- dependencies are managed by CMAKE fetchcontent
- gemma.cpp origin/main has been updated and the changes were not backcompatible with the current bindings - this is a short term fix that sets the git-tag to the first gemma.cpp commit resulting in a version that compiles without errors - TODO: update bindings to support the new interface and spec for libgemma
pagakarthik
changed the title
|
Hi @pagakarthik, thank you for contributing to this project. Your work seems good to me, we will make the release more carefully for the next time. |
|
the gemma-cpp-python still needs a lot of improvements. If you have any suggestions for us, feel free to raise your comments and suggestions. We would like to get all the feedback and make the project better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.