-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] More aggressive transpilation #11492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] More aggressive transpilation #11492
Conversation
78e0921
to
e291d6a
Compare
Update size snapshot please to see the whole picture. |
@TrySound Alright, I'm updating it. But I don't think that we can ask people to update it everytime they commit a change. |
e291d6a
to
6c388b0
Compare
@oliviertassinari We can actually. There is |
Would you like me to send a PR with it? |
@TrySound Technically, yes we can. But I mean from an operational point of view. I don't think that it worth the pain. Most of the time, we don't work on the bundling pipeline. |
What if we will just update snapshot on precommit hook? |
@TrySound I have never used a single pre-commit hook. I have always found it to slow me down. Updating the snapshot takes ~30s end-to-end unless I'm missing something. |
For prettier precommit hooks are quite fast. But yeah bundling on every commit will be noisy. |
So let's just update snapshot manually when some changes are happened. |
@@ -28,7 +28,7 @@ const generateClassName = createGenerateClassName(); | |||
// StyleSheet of the child has a higher specificity, because of the source order. | |||
// So our solution is to render sheets them in the reverse order child->sheet, so | |||
// that parent has a higher specificity. | |||
let indexCounter = Number.MIN_SAFE_INTEGER; | |||
let indexCounter = 10e10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be negative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
87bd78a
to
78e3fbb
Compare
IE 11, Safari 10, Edge 15, Firefox 45 seems OK. |
f8cae6a
to
a8a4b0d
Compare
a8a4b0d
to
6414f59
Compare
Try @goto-bus-stop's idea out #11358