Skip to content

Put webgpu_lights_pointlights in webgpu category #31107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Put webgpu_lights_pointlights in webgpu category #31107

merged 1 commit into from
May 14, 2025

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 14, 2025

Related: #31040

Description

Right now webgpu_lights_pointlights is in webgl category, it should be in webgpu

@Mugen87
Copy link
Collaborator

Mugen87 commented May 14, 2025

I did not change this on purpose so the light examples are still grouped together in the side menu.

Honestly, it does not matter which renderer is used since the light's behave equally.

@ycw
Copy link
Contributor Author

ycw commented May 14, 2025

After npm run dev, then go http://localhost:8080/examples/?q=webgpu, I saw this garbled navigation:

1

@Mugen87
Copy link
Collaborator

Mugen87 commented May 14, 2025

Um, I see. That's not ideal either.

Okay, let's merge the PR.

@Mugen87 Mugen87 merged commit ac8d338 into mrdoob:dev May 14, 2025
11 checks passed
@Mugen87 Mugen87 added this to the r177 milestone May 14, 2025
@ycw
Copy link
Contributor Author

ycw commented May 14, 2025

Thanks.

@ycw ycw deleted the 1 branch May 14, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants