ShadowNode: Clean up. #31104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev1

May 14, 2025

Collaborator

Mugen87 commented May 14, 2025

Related issue: -

Description

It seems more clean to check for the light shadow type instead of the light type. In this way the code is more consistent to WebGLRenderer.


          ShadowNode: Clean up.

b7dd14c

Mugen87 added this to the r177 milestone

github-actions bot commented May 14, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	337.26 78.64	337.26 78.64	+0 B +0 B
WebGPU	549.57 152.34	549.58 152.34	+18 B +1 B
WebGPU Nodes	548.92 152.19	548.93 152.19	+18 B +2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	467.34 112.95	467.34 112.95	+0 B +0 B
WebGPU	624.48 169.06	624.49 169.06	+18 B +3 B
WebGPU Nodes	579.33 158.35	579.34 158.35	+18 B +2 B

Mugen87 merged commit 5a55dcb into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet