Skip to content

TSL: Avoid name collision #30785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

TSL: Avoid name collision #30785

merged 3 commits into from
Mar 24, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 24, 2025

Fixes: #29969

Description

Automatically renames the property if the name is already in use.

image

@sunag sunag added this to the r175 milestone Mar 24, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.08
78.29
336.08
78.29
+0 B
+0 B
WebGPU 526.44
146.68
526.82
146.82
+384 B
+139 B
WebGPU Nodes 525.91
146.58
526.29
146.72
+384 B
+139 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.15
112.18
465.15
112.18
+0 B
+0 B
WebGPU 598.64
162.71
599.02
162.86
+384 B
+146 B
WebGPU Nodes 553.72
152.18
554.1
152.32
+384 B
+145 B

@sunag sunag marked this pull request as ready for review March 24, 2025 04:18
@sunag sunag merged commit 558068d into mrdoob:dev Mar 24, 2025
12 checks passed
@sunag sunag deleted the dev-auto-rename branch March 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL infinity loop
1 participant