Add Glean desktop tables to Shredder #7552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWu
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Tables in these datasets will automatically be shredded with these settings so this isn't needed. Any table with client id in the standard glean datasets will be shredded with the deletion request table for that dataset so you only need to add it here if it's non-standard like it's in firefox_desktop_derived but uses legacy client ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the below table to Shredder:
moz-fx-data-shared-prod.firefox_desktop_derived.baseline_clients_first_seen_v1moz-fx-data-shared-prod.firefox_desktop_derived.baseline_clients_daily_v1moz-fx-data-shared-prod.firefox_desktop_stable.baseline_v1Reviewer, please follow this checklist