-
Notifications
You must be signed in to change notification settings - Fork 114
feat: add new_profile_clients query to the mobile_kpi_support_metrics generator #7528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kik-kik
wants to merge
2
commits into
main
Choose a base branch
from
feat/DENG-8438/add-new_profile_clients-query-to-mobile_kpi-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add new_profile_clients query to the mobile_kpi_support_metrics generator #7528
kik-kik
wants to merge
2
commits into
main
from
feat/DENG-8438/add-new_profile_clients-query-to-mobile_kpi-generator
+175
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
00b1556
to
9b178de
Compare
This comment has been minimized.
This comment has been minimized.
9b178de
to
a75515f
Compare
0a05375
to
5c78fc7
Compare
Integration report for "feat: revert new_profile_clients view change until the table gets backfilled"
|
kwindau
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add new_profile_clients query to the mobile_kpi_support_metrics generator
This change aims to move all the query logic from the new_profile_clients view into a query file so that we can materialize the results each day for better performance when working with this data.
The changes include:
Follow up items: