Quickstart tutorial: Add an integration test for the expected nodes #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
reviewed
Jun 2, 2022
AndyZe
force-pushed
the
andyz/first_test
branch
2 times, most recently
from
0ae943f to
af9d9a4
Compare
|
@vatanaksoytezer this looks good to me, is it ok if i merge it or do you want to take a look? |
|
Give me a few minutes to add a trajectory test, please |
I just skimmed it real quick, generally looks good to me, feel free to merge |
AndyZe
force-pushed
the
andyz/first_test
branch
2 times, most recently
from
ce40eed to
20648c8
Compare
|
@vatanaksoytezer or @davetcoleman can I get an approval, then? I'll run CI one more time to be on the safe side |
JafarAbdi
approved these changes
Jun 2, 2022
davetcoleman
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an integration test for the first tutorial presented to new users: MoveIt Quickstart in RViz. It checks that the expected nodes and action servers are available.
I think this type of test is great to have, especially on the entry point to MoveIt for most new users. There are quite a few issues this type of test would have helped to catch in the past including [1, 2, 3, 4].
Verification
You can verify the test passes locally like so:
colcon test --packages-select moveit2_tutorials