-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5603: Add Big Endian support in BinaryVectorReader and BinaryVectorWriter #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
medhatiwari
wants to merge
10
commits into
mongodb:main
Choose a base branch
from
medhatiwari:binaryvectorsupport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ff89368
Add Big Endian Support for Float32 in BinaryVectorWriter.WriteToBytes…
2c2cae1
Added comments for clarity
medhatiwari 2c4a16a
Fix BinaryVectorSerializerTests to generate little-endian test data f…
medhatiwari 0ee1694
Add BinaryPrimitivesCompat methods for float32 little-endian serializ…
medhatiwari f43d935
Add float32 BinaryVector serialization/deserialization with endian ha…
medhatiwari 92b7ed2
added tests for new methods in BinaryPrimitivesCompat
medhatiwari 530ecda
resolved all the review comments
medhatiwari 02579c1
resolved all the comments
medhatiwari c547a15
another set of changes to resolve minor issues
medhatiwari c47d4bb
hardcoded ParamName to length
medhatiwari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.