DOC: Clean up Forward and SourceSpaces #10911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks much better! Still seeing some duplicated elements though; was that supposed to be fixed?
(screenshot from here: https://output.circle-artifacts.com/output/job/bf8fce80-1d84-49ec-b2de-baf13957a313/artifacts/0/dev/generated/mne.Forward.html#mne.Forward) |
|
That duplication is standard, there is the list of methods then below it their actual definitions. See for example |
right, of course, sorry. Do we merge this, or wait for the upstream |
|
No opinion here for me. |
|
Let's wait for the upstream PR to be merged |
larsoner
changed the title
larsoner
added a commit
to alexrockhill/mne-python
that referenced
this pull request
Jul 14, 2022
* upstream/main: to_data_frame API change (mne-tools#10925) MAINT: Fix Qt issue (mne-tools#10923) Update inverse.rst DOC (mne-tools#10922) DOC: Clean up Forward and SourceSpaces (mne-tools#10911) [MAINT, MRG] Move sensor cluster permutation example to correct directory (mne-tools#10917) [MRG] Add data loader functions for BESA files (mne-tools#10892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs numpy/numpydoc#415. Removes super class stuff we don't want to document.
Perhaps we want this for
Info, too, but there it's not so simple because we want the methods from some subclasses but not others.