Skip to content

Resume stream upload #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Resume stream upload #460

merged 6 commits into from
Jun 4, 2021

Conversation

nikithauc
Copy link
Contributor

fixes #452

Problem -
*StreamUpload.sliceFile function reads the first n bytes from the Stream.

  • If an upload fails after the 0 - n is read from the stream, then on upload resume the sliceFile function reads from n+1 bytes and 0-n is never uploaded.

Solution -

  • Added ChunkRecord interface which keeps track of the previous slice and range.
  • Compare the new upload range with the previous range and read the bytes accordingly.

@nikithauc nikithauc merged commit 710de2d into dev Jun 4, 2021
@nikithauc nikithauc mentioned this pull request Jun 8, 2021
@nikithauc nikithauc deleted the bugfix/stream-resume branch September 28, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large File Upload - retry doesn't work for StreamUpload
2 participants