Enhancement/#311 page iterator request options #318

nikithauc · 2020-08-27T09:01:15Z

Passing request options in the constructor of PageIterator Task.

spec/development/workload/PageIterator.ts

baywet · 2020-08-27T11:44:51Z

spec/development/workload/PageIterator.ts

+					assert.equal(event.start.timeZone, "UTC");
+					counter++;
+				} else {
+					assert.equal(event.start.timeZone, "Pacific Standard Time");


I'm curious: why would the 4th event and above change timezone?

The current implementation is such that if I request for the the top four events with PST timezone, the PST timezone will be applied only to the top four events while the events processed using the PageIterator will have a default timezone as the headers do not get passed in the subsequent requests. Added a test checking the if the headers passed with the PageIterator are getting applied properly.

oh thanks for the explanation! I can see how that could easily trick people, should we potentially have the header stick to the iterator so we can transparently keep sending it? (and have a consistent result across pages)

src/GraphRequest.ts

src/tasks/PageIterator.ts

ddyett · 2020-09-02T18:45:57Z

spec/development/workload/PageIterator.ts

+				return true;
+			};
+			var requestOptions = { headers: pstHeader };
+			if (response["@odata.nextLink"]) {


if there isn't a next link then we'll just assume things have passed but haven't actually tested the change.

Added a before hook to make sure that certain number of events are present/created.

spec/development/workload/PageIterator.ts

src/middleware/options/ChaosHandlerOptions.ts

…//github.com/microsoftgraph/msgraph-sdk-javascript into enhancement/#311-PageIterator_RequestOptions

* updated broken link in README * Post request with empty body, now working fine. * updated the tests for this case * made change to use undefined instead of null as classname * added functionality to simplify building middleware chain * Updated GraphRequest.ts for .count() scenario Updated GraphRequest.ts to handle .count() when no parameter is specified * Bumped version to '2.1.0-Preview.1' * Adding the Modifying middleware chain samples * - fixes broken link to client instance * Updated the example to the correct return type * fix casing on filename * Update package.json * Designed ChaosHandler * Removing the set and get middleware chain method * Update README * Update README * Bump lodash from 4.17.15 to 4.17.19 in /samples/browser Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * Changed parsepath and query functions to split query params on first equals sign considering nested queries. Added comments to query functions * Correcting spelling in comments, setting the param key directlyand replacing ternary condition with if else * Adding a buildheaders function to conditionally set content type and checking if body is null when serializing content * Altering condition to be optimal Co-authored-by: Mustafa Zengin <[email protected]> * Adding formdata to the node project, setting the esModuleInterop config as true for allowing import of npm modules, adding unit test for application/xhtml+xml content type post * Adding a private query parsing function and more validations * Adding tests for url parsing and comments to the private url parsing functions * Adding more information in the return comments for functions returning the GraphRequest instance * Adding unit test for serializecontent testing if content is null, changed content type setting for put and patch * Changing the conditional expression to check for undefined or null headers Co-authored-by: Mustafa Zengin <[email protected]> * Adding the missing return Co-authored-by: Mustafa Zengin <[email protected]> * Removing the try catch block from the test case * Removing the try catch block from the test case * Returning if the content-type is present else setting content-type as default * Uninstalling formdata, restoring the tsconfigs and removing the condition to check if form-data is undefined in GraphRequest.ts * Restoring file * Reverting the package json changes * Bump yargs-parser from 13.1.1 to 13.1.2 in /samples/browser (#321) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2. - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md) - [Commits](https://github.com/yargs/yargs-parser/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump mixin-deep from 1.3.1 to 1.3.2 in /scripts (#301) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Bump http-proxy from 1.17.0 to 1.18.1 in /samples/browser (#319) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.17.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update OneDriveLargeFileUploadTask.ts (#325) * Update OneDriveLargeFileUploadTask.ts Trying to upload files with the '#' or '%' character in the filename ends with network errors of the form - 400 status response "The parameter item does not exist in method getByPath" Encoding the entire URL does not encode URL components correctly. When the SDK's client tries to encode these URL components in the parameters on the call to OneDriveLargeFileUploadTask.create, then the resultant file in OneDrive has the URL encoded filename (as opposed to the user-friendly/decoded filename). Therefore, fix the encoding in the SDK's URL components itself, directly. * Update OneDriveLargeFileUploadTask.ts Fix typo * Update src/tasks/OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Update OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Use correct class name (#284) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Typo in documentation example. (#270) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Enhancement/#311 page iterator request options (#318) * Adding request options property to PageIterator * Adding tests for page iterator task to test passing along the headers * using headersinit type for headers * Specifying parameter definition * using constants * Updating function documentation * remove response type, test passing fetchoptions * testing requestOptions set in pageiterator * typos, optional parameters comments * Sorting parameter list - chaoshandleroptions (#334) * Client init with middleware array (#333) * Passing midddleware array in client options * Tests for middleware array * Removing try catch * ifnode condition,chain middleware test * Adding missing exports * Array initialization Co-authored-by: Vincent Biret <[email protected]> * merging with dev * Using spread operator * Checking if middleware is not empty Co-authored-by: Vincent Biret <[email protected]> * Make GraphError real Error (#335) Co-authored-by: nikithauc <[email protected]> * Using ternary shorthand, upgrade preview 2.1.0-2 (#337) * Bump version to 2.1.0 * changing.substring parameter, comments to check middleware * adding tests, urlotherqueryoptions type Co-authored-by: Abhinav Srivastava <[email protected]> Co-authored-by: muthurathinam <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: warreee <[email protected]> Co-authored-by: Gideon Goldberg <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Behnam Mohammadi <[email protected]> Co-authored-by: DeVere Dyett <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: Michael Mainer <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Hari Sridharan <[email protected]> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: mattdenkers <[email protected]> Co-authored-by: lewgordon <[email protected]> Co-authored-by: Olivier Cuypers <[email protected]>

* FIx Batching Documentation code The code example in the Batching Documentation does not work. The batchResponse is not set in the example code. * Correcting missing import, incorrect reference in example (#326) * Release - 2.1.0 (#338) * updated broken link in README * Post request with empty body, now working fine. * updated the tests for this case * made change to use undefined instead of null as classname * added functionality to simplify building middleware chain * Updated GraphRequest.ts for .count() scenario Updated GraphRequest.ts to handle .count() when no parameter is specified * Bumped version to '2.1.0-Preview.1' * Adding the Modifying middleware chain samples * - fixes broken link to client instance * Updated the example to the correct return type * fix casing on filename * Update package.json * Designed ChaosHandler * Removing the set and get middleware chain method * Update README * Update README * Bump lodash from 4.17.15 to 4.17.19 in /samples/browser Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * Changed parsepath and query functions to split query params on first equals sign considering nested queries. Added comments to query functions * Correcting spelling in comments, setting the param key directlyand replacing ternary condition with if else * Adding a buildheaders function to conditionally set content type and checking if body is null when serializing content * Altering condition to be optimal Co-authored-by: Mustafa Zengin <[email protected]> * Adding formdata to the node project, setting the esModuleInterop config as true for allowing import of npm modules, adding unit test for application/xhtml+xml content type post * Adding a private query parsing function and more validations * Adding tests for url parsing and comments to the private url parsing functions * Adding more information in the return comments for functions returning the GraphRequest instance * Adding unit test for serializecontent testing if content is null, changed content type setting for put and patch * Changing the conditional expression to check for undefined or null headers Co-authored-by: Mustafa Zengin <[email protected]> * Adding the missing return Co-authored-by: Mustafa Zengin <[email protected]> * Removing the try catch block from the test case * Removing the try catch block from the test case * Returning if the content-type is present else setting content-type as default * Uninstalling formdata, restoring the tsconfigs and removing the condition to check if form-data is undefined in GraphRequest.ts * Restoring file * Reverting the package json changes * Bump yargs-parser from 13.1.1 to 13.1.2 in /samples/browser (#321) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2. - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md) - [Commits](https://github.com/yargs/yargs-parser/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump mixin-deep from 1.3.1 to 1.3.2 in /scripts (#301) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Bump http-proxy from 1.17.0 to 1.18.1 in /samples/browser (#319) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.17.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update OneDriveLargeFileUploadTask.ts (#325) * Update OneDriveLargeFileUploadTask.ts Trying to upload files with the '#' or '%' character in the filename ends with network errors of the form - 400 status response "The parameter item does not exist in method getByPath" Encoding the entire URL does not encode URL components correctly. When the SDK's client tries to encode these URL components in the parameters on the call to OneDriveLargeFileUploadTask.create, then the resultant file in OneDrive has the URL encoded filename (as opposed to the user-friendly/decoded filename). Therefore, fix the encoding in the SDK's URL components itself, directly. * Update OneDriveLargeFileUploadTask.ts Fix typo * Update src/tasks/OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Update OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Use correct class name (#284) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Typo in documentation example. (#270) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Enhancement/#311 page iterator request options (#318) * Adding request options property to PageIterator * Adding tests for page iterator task to test passing along the headers * using headersinit type for headers * Specifying parameter definition * using constants * Updating function documentation * remove response type, test passing fetchoptions * testing requestOptions set in pageiterator * typos, optional parameters comments * Sorting parameter list - chaoshandleroptions (#334) * Client init with middleware array (#333) * Passing midddleware array in client options * Tests for middleware array * Removing try catch * ifnode condition,chain middleware test * Adding missing exports * Array initialization Co-authored-by: Vincent Biret <[email protected]> * merging with dev * Using spread operator * Checking if middleware is not empty Co-authored-by: Vincent Biret <[email protected]> * Make GraphError real Error (#335) Co-authored-by: nikithauc <[email protected]> * Using ternary shorthand, upgrade preview 2.1.0-2 (#337) * Bump version to 2.1.0 * changing.substring parameter, comments to check middleware * adding tests, urlotherqueryoptions type Co-authored-by: Abhinav Srivastava <[email protected]> Co-authored-by: muthurathinam <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: warreee <[email protected]> Co-authored-by: Gideon Goldberg <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Behnam Mohammadi <[email protected]> Co-authored-by: DeVere Dyett <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: Michael Mainer <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Hari Sridharan <[email protected]> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: mattdenkers <[email protected]> Co-authored-by: lewgordon <[email protected]> Co-authored-by: Olivier Cuypers <[email protected]> Co-authored-by: Abrax20 <[email protected]> Co-authored-by: Darrel <[email protected]> Co-authored-by: Abhinav Srivastava <[email protected]> Co-authored-by: muthurathinam <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: warreee <[email protected]> Co-authored-by: Gideon Goldberg <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Behnam Mohammadi <[email protected]> Co-authored-by: DeVere Dyett <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: Michael Mainer <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Hari Sridharan <[email protected]> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: mattdenkers <[email protected]> Co-authored-by: lewgordon <[email protected]> Co-authored-by: Olivier Cuypers <[email protected]>

* FIx Batching Documentation code The code example in the Batching Documentation does not work. The batchResponse is not set in the example code. * Correcting missing import, incorrect reference in example (#326) * Release - 2.1.0 (#338) * updated broken link in README * Post request with empty body, now working fine. * updated the tests for this case * made change to use undefined instead of null as classname * added functionality to simplify building middleware chain * Updated GraphRequest.ts for .count() scenario Updated GraphRequest.ts to handle .count() when no parameter is specified * Bumped version to '2.1.0-Preview.1' * Adding the Modifying middleware chain samples * - fixes broken link to client instance * Updated the example to the correct return type * fix casing on filename * Update package.json * Designed ChaosHandler * Removing the set and get middleware chain method * Update README * Update README * Bump lodash from 4.17.15 to 4.17.19 in /samples/browser Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * Changed parsepath and query functions to split query params on first equals sign considering nested queries. Added comments to query functions * Correcting spelling in comments, setting the param key directlyand replacing ternary condition with if else * Adding a buildheaders function to conditionally set content type and checking if body is null when serializing content * Altering condition to be optimal Co-authored-by: Mustafa Zengin <[email protected]> * Adding formdata to the node project, setting the esModuleInterop config as true for allowing import of npm modules, adding unit test for application/xhtml+xml content type post * Adding a private query parsing function and more validations * Adding tests for url parsing and comments to the private url parsing functions * Adding more information in the return comments for functions returning the GraphRequest instance * Adding unit test for serializecontent testing if content is null, changed content type setting for put and patch * Changing the conditional expression to check for undefined or null headers Co-authored-by: Mustafa Zengin <[email protected]> * Adding the missing return Co-authored-by: Mustafa Zengin <[email protected]> * Removing the try catch block from the test case * Removing the try catch block from the test case * Returning if the content-type is present else setting content-type as default * Uninstalling formdata, restoring the tsconfigs and removing the condition to check if form-data is undefined in GraphRequest.ts * Restoring file * Reverting the package json changes * Bump yargs-parser from 13.1.1 to 13.1.2 in /samples/browser (#321) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2. - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md) - [Commits](https://github.com/yargs/yargs-parser/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump mixin-deep from 1.3.1 to 1.3.2 in /scripts (#301) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Bump http-proxy from 1.17.0 to 1.18.1 in /samples/browser (#319) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.17.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update OneDriveLargeFileUploadTask.ts (#325) * Update OneDriveLargeFileUploadTask.ts Trying to upload files with the '#' or '%' character in the filename ends with network errors of the form - 400 status response "The parameter item does not exist in method getByPath" Encoding the entire URL does not encode URL components correctly. When the SDK's client tries to encode these URL components in the parameters on the call to OneDriveLargeFileUploadTask.create, then the resultant file in OneDrive has the URL encoded filename (as opposed to the user-friendly/decoded filename). Therefore, fix the encoding in the SDK's URL components itself, directly. * Update OneDriveLargeFileUploadTask.ts Fix typo * Update src/tasks/OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Update OneDriveLargeFileUploadTask.ts Updated comment Co-authored-by: Mustafa Zengin <[email protected]> * Use correct class name (#284) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Typo in documentation example. (#270) Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: nikithauc <[email protected]> * Enhancement/#311 page iterator request options (#318) * Adding request options property to PageIterator * Adding tests for page iterator task to test passing along the headers * using headersinit type for headers * Specifying parameter definition * using constants * Updating function documentation * remove response type, test passing fetchoptions * testing requestOptions set in pageiterator * typos, optional parameters comments * Sorting parameter list - chaoshandleroptions (#334) * Client init with middleware array (#333) * Passing midddleware array in client options * Tests for middleware array * Removing try catch * ifnode condition,chain middleware test * Adding missing exports * Array initialization Co-authored-by: Vincent Biret <[email protected]> * merging with dev * Using spread operator * Checking if middleware is not empty Co-authored-by: Vincent Biret <[email protected]> * Make GraphError real Error (#335) Co-authored-by: nikithauc <[email protected]> * Using ternary shorthand, upgrade preview 2.1.0-2 (#337) * Bump version to 2.1.0 * changing.substring parameter, comments to check middleware * adding tests, urlotherqueryoptions type Co-authored-by: Abhinav Srivastava <[email protected]> Co-authored-by: muthurathinam <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: warreee <[email protected]> Co-authored-by: Gideon Goldberg <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Behnam Mohammadi <[email protected]> Co-authored-by: DeVere Dyett <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: Michael Mainer <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Hari Sridharan <[email protected]> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: mattdenkers <[email protected]> Co-authored-by: lewgordon <[email protected]> Co-authored-by: Olivier Cuypers <[email protected]> * Setting GraphError prototype explicity. Version 2.1.1 (#347) Co-authored-by: Abrax20 <[email protected]> Co-authored-by: Darrel <[email protected]> Co-authored-by: Abhinav Srivastava <[email protected]> Co-authored-by: muthurathinam <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: warreee <[email protected]> Co-authored-by: Gideon Goldberg <[email protected]> Co-authored-by: Muthurathinam <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Behnam Mohammadi <[email protected]> Co-authored-by: DeVere Dyett <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: Michael Mainer <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Hari Sridharan <[email protected]> Co-authored-by: Mustafa Zengin <[email protected]> Co-authored-by: mattdenkers <[email protected]> Co-authored-by: lewgordon <[email protected]> Co-authored-by: Olivier Cuypers <[email protected]>

nikithauc added 3 commits August 16, 2020 01:11

Adding request options property to PageIterator

a36c20a

Adding tests for page iterator task to test passing along the headers

fe2bf11

using headersinit type for headers

4ec6b14

nikithauc requested review from zengin, ddyett, MIchaelMainer, peombwa and baywet August 27, 2020 09:01

baywet requested changes Aug 27, 2020

View reviewed changes

nikithauc added 3 commits August 28, 2020 00:58

Specifying parameter definition

2fa6bce

using constants

20dee50

Updating function documentation

e9dfb19

baywet previously approved these changes Sep 2, 2020

View reviewed changes

ddyett reviewed Sep 2, 2020

View reviewed changes

spec/development/workload/PageIterator.ts Show resolved Hide resolved

ddyett reviewed Sep 2, 2020

View reviewed changes

spec/development/workload/PageIterator.ts Show resolved Hide resolved

ddyett reviewed Sep 2, 2020

View reviewed changes

spec/development/workload/PageIterator.ts Outdated Show resolved Hide resolved

nikithauc mentioned this pull request Sep 8, 2020

Page Iterator Task - Design improvements microsoftgraph/msgraph-sdk-design#37

Open

remove response type, test passing fetchoptions

6c879fc

nikithauc dismissed baywet’s stale review via 6c879fc September 9, 2020 04:05

ddyett linked an issue Sep 14, 2020 that may be closed by this pull request

PageIterator should allow for sending headers with each page request #311

Closed

nikithauc added 3 commits September 24, 2020 01:07

testing requestOptions set in pageiterator

10e9c91

Merge branch 'dev' into enhancement/#311-PageIterator_RequestOptions

4bc739f

Merge branch 'dev' into enhancement/#311-PageIterator_RequestOptions

8df324f

MIchaelMainer reviewed Sep 25, 2020

View reviewed changes

nikithauc added 2 commits September 25, 2020 13:18

typos, optional parameters comments

3cf70e3

Merge branch 'enhancement/#311-PageIterator_RequestOptions' of https:…

3cebccf

…//github.com/microsoftgraph/msgraph-sdk-javascript into enhancement/#311-PageIterator_RequestOptions

MIchaelMainer approved these changes Sep 25, 2020

View reviewed changes

nikithauc merged commit 130f3c0 into dev Sep 25, 2020

nikithauc deleted the enhancement/#311-PageIterator_RequestOptions branch September 25, 2020 21:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enhancement/#311 page iterator request options #318

Enhancement/#311 page iterator request options #318

Uh oh!

nikithauc commented Aug 27, 2020

Uh oh!

Uh oh!

Uh oh!

baywet Aug 27, 2020

Uh oh!

nikithauc Aug 28, 2020

Uh oh!

baywet Aug 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddyett Sep 2, 2020

Uh oh!

nikithauc Sep 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Enhancement/#311 page iterator request options #318

Enhancement/#311 page iterator request options #318

Uh oh!

Conversation

nikithauc commented Aug 27, 2020

Uh oh!

Uh oh!

Uh oh!

baywet Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

nikithauc Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

baywet Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddyett Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

nikithauc Sep 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!