Skip to content

chore: remove unsupported version of node (12) from matrix #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MIchaelMainer
Copy link
Contributor

No description provided.

@MIchaelMainer MIchaelMainer requested a review from a team as a code owner August 14, 2023 23:18
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least add 18, maybe even 20. And maybe remove 14

@MIchaelMainer
Copy link
Contributor Author

We should at least add 18, maybe even 20. And maybe remove 14

14 still has a bit more life in it.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably align the github workflow with that.
And maybe update the policy?
Also have you tried running that workflow? a couple of weeks ago when I tried node 20 for kiota typescript I was getting failures it was impossible to install

@sebastienlevert
Copy link
Contributor

What is the impact on calling developers to up our target? Can we impact existing customers? Is that a breaking change?

If we look at https://nodejs.dev/en/about/releases/, 18 and 20 should be the one supported.

@gavinbarron
Copy link
Member

There shouldn't be any impact to consumers of the library, this would largely impact contributors. That said it's possible that by stopping testing on older versions of node an issue could arise undetected that impacts customers using those versions.

This is a tradeoff in developer time to ensure a wide range of supported node versions vs the likelihood of an issue arising vs our desire to discourage the use of an unsupported, and potentially vulnerable server environment.

16 is still in support until 9/11 and we should continue to test against that version until at least such a time as SPFx moves to using a newer version of node as it's supported development environment.

@baywet
Copy link
Member

baywet commented Aug 15, 2023

One thing to consider is that SPFx is still on node 16...

@sebastienlevert
Copy link
Contributor

So 16-20 seems to be in a good range?

@baywet
Copy link
Member

baywet commented Aug 15, 2023

IMHO yes

@sebastienlevert sebastienlevert self-requested a review August 15, 2023 16:51
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this 16-20?

@sebastienlevert
Copy link
Contributor

Though, this could mean making it a breaking change for our users. Should we delay with v4 when the work on Kiota is done?

@koros
Copy link
Contributor

koros commented Aug 17, 2023

There were some failing tests after the upgrade so I have addressed those ones on a new PR: #1405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants