Skip to content

refactor: add lint exceptions for clippy::manual_c_str_literals and clippy::ref_as_ptr #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Feb 12, 2024

These lint errors have been causing nightly clippy to fail since 2024-02-10

@wmmc88 wmmc88 self-assigned this Feb 12, 2024
@wmmc88 wmmc88 force-pushed the nightly-clippy-fix branch from e6068ce to 50f803b Compare February 12, 2024 22:44
@wmmc88 wmmc88 marked this pull request as ready for review February 12, 2024 23:03
@wmmc88 wmmc88 requested a review from a team February 12, 2024 23:03
@wmmc88 wmmc88 enabled auto-merge February 16, 2024 17:10
@wmmc88 wmmc88 added this pull request to the merge queue Feb 16, 2024
Merged via the queue into microsoft:main with commit d0e4208 Feb 16, 2024
@wmmc88 wmmc88 deleted the nightly-clippy-fix branch February 16, 2024 17:55
wmmc88 added a commit to wmmc88/windows-drivers-rs that referenced this pull request Mar 1, 2024
* refactor: add lint exceptions for clippy::manual_c_str_literals and clippy::ref_as_ptr (microsoft#108)

* re-enable wdk-sys tests

* fix!: prevent linking of wdk-libraries in tests

BREAKING CHANGES: wdk_build::Config::configure_binary_build now returns a wdk_build::ConfigError instead of ().
wmmc88 added a commit to wmmc88/windows-drivers-rs that referenced this pull request Apr 8, 2024
* refactor: add lint exceptions for clippy::manual_c_str_literals and clippy::ref_as_ptr (microsoft#108)

* ci: fix various pipeline breakages (nightly rustfmt bug, new nightly clippy lints, upstream winget dependency issue) (microsoft#117)

* docs: fix `winget` llvm install command option (microsoft#115)

Signed-off-by: Nicholas Rishel <[email protected]>
Co-authored-by: Melvin Wang <[email protected]>

* fix!: prevent linking of wdk libraries in tests that depend on `wdk-sys` (microsoft#118)

* refactor: change version bounds for `manual_c_str_literals` and `ref_as_ptr` clippy lints (microsoft#127)

Signed-off-by: Melvin Wang <[email protected]>

* Revert "Fix wdk sys ci tests (#23)"

This reverts commit 165f26a.

---------

Signed-off-by: Nicholas Rishel <[email protected]>
Signed-off-by: Melvin Wang <[email protected]>
Co-authored-by: Nicholas Rishel <[email protected]>
@wmmc88 wmmc88 mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants