Fix missed Previewer.plain call due to adjacent @ts-expect-error #121975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a
// @ts-expect-error until 4.3 protocol update
comment in some completions code in #119009, but it unintentionally silenced an error that should have arisen as part of @mjbvz’s refactor in #119358. I’ve fixed that, and also shuffled some of the remaining temporary// @ts-expect-error
comments to target less code.I also wrote a smoke test to add to
completions.test.ts
, but I’m not sure how to run it (without running all smoke tests), and I have low confidence I wrote it correctly, so I haven’t committed it yet. But the content isI also suppose this won’t work until smoke tests are run against TypeScript 4.3, and I’m not sure how that works either.