Skip to content

Adopt utility process for shared process and file watchers #154050

Closed
@bpasero

Description

@bpasero

This is a follow up from #92164 and covers remaining work to eventually enable sandboxed renderers fully in Electron via app.enableSandbox().

This means that our shared process has to move away from a node.js enabled browser window to the new utility process.

Breaking down the usages today:

  • extension management
  • settings sync
  • profiles
  • terminals
  • file watcher

Some initial thoughts:

  • the shared process should probably just change to be a utility process as a first step
    • however, any code that relies on the browser window network stack instead has to leverage Electrons net APIs from the electron-main process to not loose proxy support
    • this can probably be done by implementing some kind of IRequestService that is backed by a main process service implementation
  • any child process has to decide whether it wants to lift up to a utility process off the main process or remain inside the shared process

//cc @alexdima

Metadata

Metadata

Labels

on-testplanplan-itemVS Code - planned item for upcomingsandboxRunning VSCode in a node-free environmentshared-processVS Code shared process issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions