Add back links and refer to MDN. FIx #12 #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Aug 21, 2019
src/languageFacts/dataProvider.ts
Outdated
| description: a.description, | ||
| valueSet: a.valueSet | ||
| }); | ||
| attributes.push({ ...a }); |
There was a problem hiding this comment.
Is it necessary to provide a clone?
src/languageFacts/dataProvider.ts
Outdated
| * Generate MarkupContent used in hover/complete | ||
| * From `documentation` and `references` | ||
| */ | ||
| export function generateMarkupcontent(item: ITagData | IAttributeData | IValueData): MarkupContent { |
There was a problem hiding this comment.
IMO it would make sense to have the 'supportMarkdown' flag passed in here so that the content can be streamlined also for clients that can't handle markdown. E.g. You would then just add the links as is.
Then you don't need an extra step to convert the hover afterwards
There was a problem hiding this comment.
Maybe find a better name generateDocumentation(..) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.