[Enhancement] GDB attach config in Linux should not have "program" as a required parameter

[Ranjan163]

Type: Debugger

Describe the bug

• OS and Version: Linux (All versions)
• VS Code Version: 1.46.1
• C/C++ Extension Version: v0.29.0-insiders
• Other extensions you installed (and if the issue persists after disabling them): Not Applicable
• A clear and concise description of what the bug is.

I have been using VS Code with C/C++ Debugger extensively for debugging running applications in Linux
GDB attach config in Linux currently needs path to executable i.e. the "program" parameter in launch.json
This parameter is marked as "required" in the json schema
Standalone GDB can attach to a process using just the "pid".

Can this extension be enhanced to support attach configuration with just a pid / attachQuickPick
If the executable path is necessary, then I suppose it can be queried using proc file system (/proc/'pid'/cmdline or /proc/'pid'/exe)

To Reproduce
Please include a code sample and launch.json configuration.
Steps to reproduce the behavior:

1. Use the attached "launch.json"
   launch.json.zip

2. Start this launch config

3. Select a process to attach the debugger to

4. A popup is displayed that attach property "program" is missing ("1.png")
   

)

Additional context
If applicable, please include logging by adding "logging": { "engineLogging": true, "trace": true, "traceResponse": true } in your launch.json
Add any other context about the problem here including log or error messages in your Debug Console or Output windows.

[WardenGnaw]

Thank you for your enhancement suggestion.

Our debug adapter uses program in the attach configuration to tell gdb what to load for symbols.

If the executable path is necessary, then I suppose it can be queried using proc file system (/proc/'pid'/cmdline or /proc/'pid'/exe)

This extension supports both Windows and Linux based platforms, querying /proc/<pid>/ unfortunatly would not work on Windows.

The other scenario that needs to be covered is if a user is using SSH to attach to a remote process, we will need to retrieve information on that remote machine that may be running Windows or Linux.

Here is where we retrieve program from the launch configuration.
We can not use Process.GetProcessById() here since this would only cover the local scenario and not the remote scenario.

Here is where we require program to load symbols for the debuggee process.

[Ranjan163]

Thanks Andrew for the pointers. So far I was only looking at the extension sources and had no cycles to check the MIEngine code
I assume any OS specific changes won't be taken up.
I'll try to customize it myself if this is the case and you can close this issue

If you plan on addressing this enhancement, then that would be great!!

[Ranjan163]

Here's what I did with "AD7DebugSession.cs" and now I can get the required behavior
string program = isLocal ? Process.GetProcessById(pid).MainModule.FileName : responder.Arguments.ConfigurationProperties.GetValueAsString("program");

This should work for both native windows and linux attach as well as remote attach
Thanks again for your help!!

[OEP]

I like this solution. I couldn't tell if it addresses all of the concerns about the remote vs local scenario. If it does, would a PR be welcomed in MIEngine?