Skip to content

Set typescript.native-preview.serverRunning=false on extension startup #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Set typescript.native-preview.serverRunning=false on extension startup #998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { setupStatusBar } from "./statusBar";
import { setupVersionStatusItem } from "./versionStatusItem";

export async function activate(context: vscode.ExtensionContext) {
await vscode.commands.executeCommand("setContext", "typescript.native-preview.serverRunning", false);
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment explaining the rationale behind resetting the 'typescript.native-preview.serverRunning' context on activation to improve clarity for future maintenance.

Copilot uses AI. Check for mistakes.


const output = vscode.window.createOutputChannel("typescript-native-preview", "log");
const traceOutput = vscode.window.createOutputChannel("typescript-native-preview (LSP)");
const client = new Client(output, traceOutput);
Expand Down