Skip to content

Remove old parser tests #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Remove old parser tests #960

merged 1 commit into from
May 28, 2025

Conversation

jakebailey
Copy link
Member

These were useful back when we were just porting stuff to verify that we weren't crashing, but now it's 20k extra tests that are largely already tested by the now-working compiler test suite.

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 01:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the legacy TestParseTypeScriptRepo suite and unused imports to slim down the parser test file.

  • Deleted the monolithic TestParseTypeScriptRepo which iterated over the TypeScript submodule.
  • Removed now-unused imports (strings, ast) tied to the deleted test.
  • Retained and cleaned up the benchmark and parsing helpers.
Comments suppressed due to low confidence (3)

internal/parser/parser_test.go:11

  • The repo import is no longer used after removing TestParseTypeScriptRepo; consider deleting this import to avoid dead code.
"github.com/microsoft/typescript-go/internal/repo"

internal/parser/parser_test.go:48

  • The parsableFile struct is no longer referenced after removing the parser tests; you may want to remove it to keep the file clean.
type parsableFile struct {

internal/parser/parser_test.go:47

  • [nitpick] Removing this broad integration test reduces overall parser coverage; consider adding smaller, targeted unit tests for key syntax scenarios.
func TestParseTypeScriptRepo(t *testing.T) {

@jakebailey jakebailey added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit cd7a8f6 May 28, 2025
23 checks passed
@jakebailey jakebailey deleted the jabaile/remove-old-parser-tests branch May 29, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants