Skip to content

Hardcode contents of typesMap.json #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Hardcode contents of typesMap.json #1002

merged 2 commits into from
May 30, 2025

Conversation

sheetalkamat
Copy link
Member

No description provided.

@sheetalkamat sheetalkamat requested review from Copilot and jakebailey and removed request for Copilot May 30, 2025 22:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR hardcodes the contents of typesMap.json by removing the dynamic safeList and typesMap file loading, and updates logging messages from "TI::" to "ATA::".

  • Removed safeList parameter from functions and associated code in tests and implementation.
  • Renamed logging prefixes and test function names to reflect the new "ATA" naming convention.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
internal/project/discovertypings_test.go Removed safeList map parameter from test cases.
internal/project/discovertypings.go Removed safeList parameter and updated logging messages.
internal/project/ata_test.go Renamed test function from TestTi to TestAta.
internal/project/ata.go Removed typesMap and safeList related types and functions; updated logging.
Comments suppressed due to low confidence (1)

internal/project/discovertypings.go:127

  • The reference to 'safeList' in getTypingNamesFromSourceFileNames remains even though the parameter has been removed, which will likely result in a compilation error. Please update the function to remove this reference or pass 'safeList' using an alternative approach.
if safeName, ok := safeList[cleanedTypingName]; ok {

@sheetalkamat sheetalkamat requested a review from jakebailey May 30, 2025 22:42
@sheetalkamat sheetalkamat enabled auto-merge May 30, 2025 22:45
@sheetalkamat sheetalkamat added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 7bcea23 May 30, 2025
23 checks passed
@sheetalkamat sheetalkamat deleted the embedTypesMap branch May 30, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants