globbing in include isn't working properly under tsgo

[joshcartme]

repro: https://github.com/joshcartme/tsgo-glob-bug
using: 7.0.0-dev.20250529.1

In the above repo I've got a nested tsconfig.json that includes some files by having "../../ambient-types/**/*" in it's include. This works fine under tsc but does not work with tsgo. It does work with tsgo if the include is changed to "../../ambient-types/*" or "../../ambient-types"

tsc:

$ yarn run tsc --project lib/core/tsconfig.json
yarn run v1.22.22
$ /home/repro/development/tsgo-glob-bug/node_modules/.bin/tsc --project lib/core/tsconfig.json
Done in 0.59s.

tsgo:

$ yarn run tsgo --project lib/core/tsconfig.json
yarn run v1.22.22
$ /home/repro/development/tsgo-glob-bug/node_modules/.bin/tsgo --project lib/core/tsconfig.json
lib/core/index.ts:1:14 - error TS2304: Cannot find name '$FixMe'.

1 const fixMe: $FixMe = '';
               ~~~~~~

Found 1 error in lib/core/index.ts:1

Using the root tsconfig.json which has ambient-types/**/* in it's include works find with tsc and tsgo so it seems to be something about the combination of a relative url that has a glob pattern in it.

[joshcartme]

I think I've tracked this down, it is because an include like ../../ambient-types/**/* is turned into an absolute path, let's say /home/dev/project/ambient-types/**/* and passed here

typescript-go/internal/vfs/utilities.go

Lines 241 to 252 in e8d352c

	func getIncludeBasePath(absolute string) string {
	wildcardOffset := strings.IndexAny(absolute, string(wildcardCharCodes))
	if wildcardOffset < 0 {
	// No "*" or "?" in the path
	if !tspath.HasExtension(absolute) {
	return absolute
	} else {
	return tspath.RemoveTrailingDirectorySeparator(tspath.GetDirectoryPath(absolute))
	}
	}
	return absolute[:strings.LastIndex(absolute, string(tspath.DirectorySeparator))]
	}

That strips the last chunk of the path, so returns /home/dev/project/ambient-types/**. Then patterns in

typescript-go/internal/vfs/utilities.go

Line 425 in e8d352c

patterns := getFileMatcherPatterns(path, excludes, includes, useCaseSensitiveFileNames, currentDirectory)

ends up with one of it's base paths as /home/dev/project/ambient-types/** and that is not a valid path to visit in

typescript-go/internal/vfs/utilities.go

Lines 370 to 382 in e8d352c

	func (v *visitor) visitDirectory(
	path string,
	absolutePath string,
	depth *int,
	) {
	canonicalPath := tspath.GetCanonicalFileName(absolutePath, v.useCaseSensitiveFileNames)
	if v.visited.Has(canonicalPath) {
	return
	}
	v.visited.Add(canonicalPath)
	systemEntries := v.host.GetAccessibleEntries(absolutePath)
	files := systemEntries.Files
	directories := systemEntries.Directories

so systemEntries.Files and systemEntries.Directories are empty and any files represented by that include are not found.

Thing do work with implicit globs, so if that include was ../../ambient-types the basePath ends up as /home/dev/project/ambient-types and the files and/or directories are found.

I'm not sure I'm qualified, but I think this is a fix #1004

[joshcartme]

Fixed by #1004