-
Notifications
You must be signed in to change notification settings - Fork 992
[BUG] Frame is emitted on Page events domcontentloaded/load #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oops! Thanks for pointing this out. Let me update and add test coverage here. |
rwoll
added a commit
to rwoll/playwright-python
that referenced
this issue
Jul 3, 2022
Fixes microsoft#1399. Ports in microsoft#1374 of microsoft/playwright@cdb8627 was incorrect.
Once #1400, we'll put it into a patch release of the Python 1.23 version. Thanks! |
rwoll
added a commit
that referenced
this issue
Jul 4, 2022
Fixes #1399. Ports in #1374 of microsoft/playwright@cdb8627 was incorrect.
rwoll
added a commit
to rwoll/playwright-python
that referenced
this issue
Jul 4, 2022
Fixes microsoft#1399. Ports in microsoft#1374 of microsoft/playwright@cdb8627 was incorrect.
rwoll
added a commit
that referenced
this issue
Jul 5, 2022
Fixes #1399. Ports in #1374 of microsoft/playwright@cdb8627 was incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context:
Code Snippet
Describe the bug
The code above prints
Frame
in 1.23, which wasPage
in 1.22.The JS version of Playwright still prints Page with the similar code, so I think this is an unexpected change.
The change would be made here: https://github.com/microsoft/playwright-python/pull/1374/files#diff-532b443f553121e300cafcb5964712250d091576e944af3b880ba143e1413c28R103
The text was updated successfully, but these errors were encountered: