Skip to content

feat(tools): implement cypress-component-configuration generator #28115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 2, 2023

Previous Behavior

  • just.config template contains backtick that triggers error on file parsing
  • cypress config was only "setup" (updated) if there was a tsconfig.cy.json present in project

New Behavior

  • just.config template works
  • cypress config will be updated if it already exists within a project when running migrate-converged-pkg
  • to add cypress component testing to your project you need to explicitly create it via cypress-component-configuration generator

DEMO:

yarn nx workspace-generator cypress-component-configuration --project=@fluentui/react-text

  1. adding by providing --project
image
  1. adding by using interactive prompt
image
  1. no-op if used on application
image

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 2, 2023

📊 Bundle size report

🤖 This report was generated against cf6b94ba6559236150bc1f1814b023607edaeb20

@size-auditor
Copy link

size-auditor bot commented Jun 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cf6b94ba6559236150bc1f1814b023607edaeb20 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0515f7c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Hotell Hotell marked this pull request as ready for review June 2, 2023 11:57
@Hotell Hotell requested a review from a team as a code owner June 2, 2023 11:57
@Hotell Hotell force-pushed the hotell/tools/fix-migrate-pkg-gen branch from da0578f to 0515f7c Compare June 16, 2023 12:43
@Hotell Hotell merged commit d6d9298 into microsoft:master Jun 16, 2023
@Hotell Hotell deleted the hotell/tools/fix-migrate-pkg-gen branch June 16, 2023 13:40
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 20, 2023
* master: (32 commits)
  applying package updates
  feat(react-tags): add styles for size (microsoft#28229)
  docs(react-dialog): update DialogTriggerOutsideDialog to include focus behavior (microsoft#28176)
  bugfix: Ensures dialog actions stretches on breakpoints (microsoft#28258)
  applying package updates
  fix: TableHeaderCell should not render button when not sortable (microsoft#28097)
  fix(react-file-type-icons): Map mhtml extension to html icon (microsoft#28112)
  Fix overlapping axis labels on smaller viewports (microsoft#28239)
  useArrowNavigationGroup grid-linear axis (microsoft#28253)
  applying package updates
  fix: Alert example missing aria-label for icon (microsoft#28234)
  Overflow divider fix (microsoft#28011)
  feat(tools): implement `cypress-component-configuration` generator (microsoft#28115)
  chore: migrate to TS 4.7 (microsoft#28067)
  fix(scripts-tasks): make generate-api work in deterministic way (microsoft#28215)
  feat(react-tags): add overflow story (microsoft#28012)
  Structure and slots for SearchBox, using Input as a slot (microsoft#28090)
  feat(tokens): Add/update theme tokens (microsoft#27791)
  feat(react-tags): add a11y role and best practices guide (microsoft#28075)
  fix: Toast intent should always be present in the context (microsoft#28226)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nx migrate-converged-pkg not updating tsconfig for cypress
5 participants