Allow multiple 'this' property assignments in Salsa #6679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //// if (age >= 18) { | ||
| //// this.canVote = true; | ||
| //// } else { | ||
| //// this.canVote = false; |
There was a problem hiding this comment.
What is the resulting type if the assignments are of different (incompatible) types (e.g. a boolean and an arrow function)? Do you get any errors or intellisense off the resulting type?
It would be good to add a test to cover that scenario for both documentation and regression purposes.
EDIT: Per discussion - ideally would be a union type.
|
Minor comment. 👍 once that is captured. |
RyanCavanaugh
added a commit
that referenced
this pull request
Feb 2, 2016
Allow multiple 'this' property assignments in Salsa
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6645