5.5 deprecations are no-ops, not errors #58313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Apr 25, 2024
| @@ -4593,10 +4594,10 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
Would probably be even better to add new diags in the middle here that says "is deprecated and has stopped functioning", since it'll be in future tense even when we're on like TS 5.6.
|
Sorry about this; I think I made this stricter than you intended when I refactored things a bit back in 5.0. |
| @@ -1,8 +1,8 @@ | |||
| error TS5102: Option 'noImplicitUseStrict' has been removed. Please remove it from your configuration. | |||
| error TS5101: Option 'noImplicitUseStrict' is deprecated and will stop functioning in TypeScript 5.5. Specify compilerOption '"ignoreDeprecations": "5.0"' to silence this error. | |||
There was a problem hiding this comment.
Like Jake said,
Suggested change
| error TS5101: Option 'noImplicitUseStrict' is deprecated and will stop functioning in TypeScript 5.5. Specify compilerOption '"ignoreDeprecations": "5.0"' to silence this error. | |
| error TS5101: Option 'noImplicitUseStrict' is deprecated and has stopped functioning in TypeScript 5.5. Specify compilerOption '"ignoreDeprecations": "5.0"' to silence this error. |
would be better. I'll approve, but we should probably update this.
DanielRosenwasser
approved these changes
Apr 25, 2024
|
Going to merge for the beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #51000 we said
So the correct behavior under e.g.
is to not error, but instead to pretend we didn't see
keyofStringsOnly