Skip to content

correctly capture 'this' when converting loops into functions #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2015

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Nov 22, 2015

fixes #5746

@@ -403,6 +403,11 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi
argumentsName?: string;

/*
* alias for 'this' from the calline code stack frame in case if this was used inside the converted loop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calline -> calling

@RyanCavanaugh
Copy link
Member

👍

vladima added a commit that referenced this pull request Nov 23, 2015
correctly capture 'this' when converting loops into functions
@vladima vladima merged commit fbaba90 into master Nov 23, 2015
@vladima vladima deleted the thisWithLetConst branch November 23, 2015 05:53
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'this' not appropriately captured when downleveling loop with block-scoped variable
3 participants