Skip to content

Destructure scanner methods in parser #53144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Destructure scanner methods in parser #53144

wants to merge 2 commits into from

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Mar 7, 2023

This might be faster!

Addresses #52959

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023
@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 2f30aee. You can monitor the build here.

Update: The results are in!

@sandersn
Copy link
Member Author

sandersn commented Mar 7, 2023 •
edited
Loading

Local run on node 19 with --predictable shows no changes in overall time except for TFS, which gets 1% faster (and nearly every stage's timings jump around). xstate's parsing gets 1% faster too, which indicates to me that all those scanner.getTokenPos calls in the JSDoc parsing were costing us something.

If the perf machine agrees, this is a good change even if it's only a small bump.

Edit: who knows, the performance bump might happen just because there's less source text.

@sandersn
Copy link
Member Author

sandersn commented Mar 7, 2023 •
edited
Loading

The failing test failed to download the action at all. I don't think it's relevant in any case.

jakebailey
jakebailey reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some subset of these we could inline instead of doing all of them, sorta like we did factories?

src/compiler/parser.ts
getTokenText,
getTokenValue,
hasExtendedUnicodeEscape,
hasExtendedUnicodeEscape: scanner_hasExtendedUnicodeEscape,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it bad that I wish these all were scanner_ prefixed? Maybe it's not such a big deal to remember where these come from, I suppose.

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53144
Metric main 53144 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 362,595k (± 0.01%) 359,800k (± 0.01%) -2,795k (- 0.77%) 359,769k 359,842k p=0.005 n=6
Parse Time 3.39s (± 0.79%) 3.53s (± 1.26%) +0.14s (+ 4.19%) 3.47s 3.59s p=0.005 n=6
Bind Time 1.12s (± 0.88%) 1.12s (± 0.73%) ~ 1.11s 1.13s p=0.394 n=6
Check Time 8.69s (± 0.66%) 8.63s (± 0.20%) -0.07s (- 0.81%) 8.60s 8.65s p=0.018 n=6
Emit Time 7.44s (± 1.11%) 7.44s (± 0.79%) ~ 7.35s 7.50s p=0.748 n=6
Total Time 20.63s (± 0.57%) 20.72s (± 0.50%) ~ 20.58s 20.87s p=0.261 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 190,934k (± 0.01%) 193,627k (± 1.60%) ~ 190,774k 196,540k p=1.000 n=6
Parse Time 1.51s (± 0.91%) 1.48s (± 0.82%) -0.04s (- 2.53%) 1.47s 1.50s p=0.007 n=6
Bind Time 0.77s (± 0.53%) 0.77s (± 0.82%) ~ 0.76s 0.78s p=0.673 n=6
Check Time 9.40s (± 1.24%) 9.35s (± 0.79%) ~ 9.23s 9.45s p=0.574 n=6
Emit Time 2.72s (± 1.05%) 2.73s (± 0.76%) ~ 2.70s 2.75s p=0.466 n=6
Total Time 14.40s (± 0.81%) 14.32s (± 0.73%) ~ 14.17s 14.48s p=0.296 n=6
Monaco - node (v18.10.0, x64)
Memory used 347,409k (± 0.01%) 343,848k (± 0.01%) -3,561k (- 1.03%) 343,802k 343,888k p=0.005 n=6
Parse Time 2.57s (± 0.68%) 2.60s (± 0.76%) +0.04s (+ 1.49%) 2.57s 2.63s p=0.012 n=6
Bind Time 1.00s (± 0.83%) 1.01s (± 0.51%) ~ 1.00s 1.01s p=0.533 n=6
Check Time 7.02s (± 0.44%) 7.01s (± 0.57%) ~ 6.95s 7.07s p=0.687 n=6
Emit Time 4.21s (± 0.84%) 4.25s (± 0.84%) ~ 4.23s 4.32s p=0.120 n=6
Total Time 14.80s (± 0.21%) 14.88s (± 0.48%) +0.08s (+ 0.52%) 14.82s 15.01s p=0.023 n=6
TFS - node (v18.10.0, x64)
Memory used 300,776k (± 0.01%) 299,829k (± 0.01%) -947k (- 0.31%) 299,799k 299,846k p=0.005 n=6
Parse Time 2.07s (± 1.00%) 2.02s (± 1.84%) -0.05s (- 2.33%) 1.99s 2.09s p=0.041 n=6
Bind Time 1.14s (± 0.66%) 1.13s (± 0.46%) ~ 1.13s 1.14s p=0.069 n=6
Check Time 6.52s (± 0.25%) 6.49s (± 0.20%) -0.02s (- 0.38%) 6.47s 6.51s p=0.023 n=6
Emit Time 3.85s (± 0.67%) 3.83s (± 0.63%) ~ 3.80s 3.87s p=0.089 n=6
Total Time 13.59s (± 0.39%) 13.48s (± 0.32%) -0.11s (- 0.81%) 13.41s 13.53s p=0.006 n=6
material-ui - node (v18.10.0, x64)
Memory used 477,515k (± 0.01%) 476,476k (± 0.00%) -1,040k (- 0.22%) 476,465k 476,484k p=0.005 n=6
Parse Time 2.91s (± 0.77%) 3.14s (± 0.31%) +0.23s (+ 7.84%) 3.13s 3.15s p=0.005 n=6
Bind Time 1.07s (± 1.72%) 0.91s (± 0.57%) 🟩-0.16s (-15.13%) 0.90s 0.91s p=0.004 n=6
Check Time 17.02s (± 0.41%) 17.04s (± 0.43%) ~ 16.91s 17.11s p=0.520 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.00s (± 0.31%) 21.09s (± 0.34%) +0.09s (+ 0.42%) 20.96s 21.17s p=0.045 n=6
xstate - node (v18.10.0, x64)
Memory used 550,391k (± 0.02%) 548,886k (± 0.02%) -1,505k (- 0.27%) 548,767k 549,041k p=0.005 n=6
Parse Time 3.75s (± 0.67%) 4.03s (± 0.64%) +0.28s (+ 7.50%) 4.01s 4.08s p=0.005 n=6
Bind Time 1.68s (± 0.31%) 1.68s (± 0.75%) ~ 1.67s 1.70s p=0.448 n=6
Check Time 2.77s (± 0.70%) 2.77s (± 1.06%) ~ 2.74s 2.81s p=1.000 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.29s (± 0.38%) 8.56s (± 0.48%) +0.27s (+ 3.30%) 8.52s 8.61s p=0.005 n=6
Angular - node (v16.17.1, x64)
Memory used 361,955k (± 0.00%) 359,085k (± 0.00%) -2,871k (- 0.79%) 359,077k 359,096k p=0.005 n=6
Parse Time 3.51s (± 0.59%) 3.71s (± 0.71%) +0.20s (+ 5.75%) 3.67s 3.73s p=0.005 n=6
Bind Time 1.19s (± 0.69%) 1.20s (± 0.68%) ~ 1.19s 1.21s p=0.077 n=6
Check Time 9.47s (± 0.64%) 9.46s (± 1.10%) ~ 9.34s 9.65s p=0.574 n=6
Emit Time 7.89s (± 0.91%) 7.92s (± 0.46%) ~ 7.88s 7.98s p=0.296 n=6
Total Time 22.04s (± 0.49%) 22.28s (± 0.53%) +0.24s (+ 1.09%) 22.16s 22.48s p=0.008 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,714k (± 0.02%) 192,360k (± 0.04%) -354k (- 0.18%) 192,260k 192,473k p=0.005 n=6
Parse Time 1.58s (± 0.93%) 1.56s (± 0.99%) ~ 1.53s 1.57s p=0.116 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.00%) ~ 0.82s 0.82s p=0.405 n=6
Check Time 10.12s (± 0.36%) 10.11s (± 0.99%) ~ 9.97s 10.20s p=0.809 n=6
Emit Time 2.99s (± 0.80%) 2.99s (± 0.47%) ~ 2.97s 3.01s p=1.000 n=6
Total Time 15.51s (± 0.21%) 15.47s (± 0.75%) ~ 15.31s 15.58s p=0.810 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,691k (± 0.01%) 343,110k (± 0.01%) -3,581k (- 1.03%) 343,072k 343,148k p=0.005 n=6
Parse Time 2.72s (± 0.30%) 2.76s (± 0.71%) +0.05s (+ 1.72%) 2.75s 2.80s p=0.004 n=6
Bind Time 1.09s (± 0.50%) 1.08s (± 1.01%) ~ 1.06s 1.09s p=0.476 n=6
Check Time 7.75s (± 0.56%) 7.67s (± 0.34%) -0.08s (- 1.03%) 7.63s 7.70s p=0.005 n=6
Emit Time 4.42s (± 0.80%) 4.45s (± 1.04%) ~ 4.39s 4.51s p=0.376 n=6
Total Time 15.97s (± 0.41%) 15.96s (± 0.48%) ~ 15.87s 16.06s p=0.574 n=6
TFS - node (v16.17.1, x64)
Memory used 300,133k (± 0.01%) 299,180k (± 0.00%) -953k (- 0.32%) 299,172k 299,188k p=0.005 n=6
Parse Time 2.17s (± 0.48%) 2.14s (± 0.30%) -0.03s (- 1.61%) 2.13s 2.15s p=0.004 n=6
Bind Time 1.24s (± 1.07%) 1.25s (± 0.65%) ~ 1.24s 1.26s p=0.796 n=6
Check Time 7.17s (± 0.19%) 7.17s (± 0.57%) ~ 7.11s 7.20s p=0.570 n=6
Emit Time 4.33s (± 0.27%) 4.33s (± 0.45%) ~ 4.30s 4.35s p=0.625 n=6
Total Time 14.92s (± 0.20%) 14.88s (± 0.27%) ~ 14.82s 14.94s p=0.124 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,817k (± 0.00%) 475,790k (± 0.00%) -1,027k (- 0.22%) 475,748k 475,812k p=0.005 n=6
Parse Time 3.21s (± 0.16%) 3.30s (± 0.25%) +0.09s (+ 2.81%) 3.29s 3.31s p=0.004 n=6
Bind Time 0.96s (± 0.42%) 0.95s (± 0.00%) -0.01s (- 1.21%) 0.95s 0.95s p=0.002 n=6
Check Time 18.09s (± 0.44%) 18.03s (± 0.28%) ~ 17.97s 18.10s p=0.148 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.26s (± 0.34%) 22.27s (± 0.24%) ~ 22.22s 22.36s p=0.574 n=6
xstate - node (v16.17.1, x64)
Memory used 548,077k (± 0.02%) 546,475k (± 0.02%) -1,603k (- 0.29%) 546,304k 546,630k p=0.005 n=6
Parse Time 3.93s (± 0.19%) 4.24s (± 0.13%) +0.31s (+ 7.81%) 4.23s 4.24s p=0.004 n=6
Bind Time 1.79s (± 0.50%) 1.77s (± 0.77%) -0.02s (- 1.30%) 1.75s 1.79s p=0.019 n=6
Check Time 2.99s (± 0.50%) 2.99s (± 0.63%) ~ 2.97s 3.02s p=0.802 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.80s (± 0.33%) 9.08s (± 0.30%) +0.28s (+ 3.14%) 9.05s 9.11s p=0.005 n=6
Angular - node (v14.15.1, x64)
Memory used 355,752k (± 0.01%) 352,886k (± 0.00%) -2,866k (- 0.81%) 352,869k 352,899k p=0.005 n=6
Parse Time 3.57s (± 0.41%) 3.74s (± 0.40%) +0.17s (+ 4.72%) 3.72s 3.76s p=0.005 n=6
Bind Time 1.22s (± 0.33%) 1.24s (± 0.67%) +0.02s (+ 1.91%) 1.24s 1.26s p=0.003 n=6
Check Time 9.78s (± 0.53%) 9.67s (± 0.32%) -0.10s (- 1.04%) 9.63s 9.72s p=0.008 n=6
Emit Time 8.31s (± 0.56%) 8.26s (± 0.62%) ~ 8.18s 8.32s p=0.147 n=6
Total Time 22.87s (± 0.41%) 22.92s (± 0.34%) ~ 22.81s 23.01s p=0.377 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,934k (± 0.02%) 187,675k (± 0.01%) -259k (- 0.14%) 187,641k 187,693k p=0.005 n=6
Parse Time 1.60s (± 0.92%) 1.55s (± 0.67%) -0.04s (- 2.71%) 1.54s 1.57s p=0.005 n=6
Bind Time 0.85s (± 0.65%) 0.84s (± 0.62%) -0.01s (- 0.99%) 0.83s 0.84s p=0.038 n=6
Check Time 10.17s (± 0.37%) 10.14s (± 0.39%) ~ 10.10s 10.20s p=0.172 n=6
Emit Time 3.11s (± 0.39%) 3.12s (± 1.24%) ~ 3.08s 3.19s p=0.870 n=6
Total Time 15.71s (± 0.27%) 15.65s (± 0.37%) ~ 15.59s 15.74s p=0.078 n=6
Monaco - node (v14.15.1, x64)
Memory used 341,677k (± 0.01%) 338,146k (± 0.01%) -3,531k (- 1.03%) 338,115k 338,172k p=0.005 n=6
Parse Time 2.83s (± 0.57%) 2.88s (± 0.36%) +0.04s (+ 1.59%) 2.86s 2.89s p=0.006 n=6
Bind Time 1.10s (± 0.68%) 1.09s (± 0.50%) ~ 1.09s 1.10s p=0.476 n=6
Check Time 8.12s (± 0.57%) 8.05s (± 0.48%) -0.07s (- 0.82%) 8.00s 8.10s p=0.030 n=6
Emit Time 4.67s (± 0.62%) 4.69s (± 0.65%) ~ 4.64s 4.73s p=0.169 n=6
Total Time 16.71s (± 0.38%) 16.71s (± 0.32%) ~ 16.64s 16.79s p=1.000 n=6
TFS - node (v14.15.1, x64)
Memory used 295,238k (± 0.00%) 294,311k (± 0.01%) -927k (- 0.31%) 294,272k 294,340k p=0.005 n=6
Parse Time 2.39s (± 0.81%) 2.40s (± 0.89%) ~ 2.38s 2.44s p=0.511 n=6
Bind Time 1.07s (± 0.70%) 1.06s (± 0.77%) ~ 1.06s 1.08s p=0.206 n=6
Check Time 7.50s (± 0.29%) 7.44s (± 0.36%) -0.06s (- 0.84%) 7.40s 7.47s p=0.006 n=6
Emit Time 4.28s (± 0.64%) 4.29s (± 0.95%) ~ 4.24s 4.34s p=0.936 n=6
Total Time 15.25s (± 0.30%) 15.19s (± 0.50%) ~ 15.09s 15.32s p=0.092 n=6
material-ui - node (v14.15.1, x64)
Memory used 472,457k (± 0.01%) 471,419k (± 0.01%) -1,037k (- 0.22%) 471,386k 471,453k p=0.005 n=6
Parse Time 3.34s (± 0.55%) 3.48s (± 0.34%) +0.14s (+ 4.19%) 3.47s 3.50s p=0.005 n=6
Bind Time 1.00s (± 0.63%) 1.00s (± 0.63%) ~ 0.99s 1.01s p=1.000 n=6
Check Time 19.06s (± 0.76%) 18.88s (± 0.28%) -0.18s (- 0.97%) 18.82s 18.94s p=0.037 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.40s (± 0.65%) 23.37s (± 0.21%) ~ 23.30s 23.43s p=0.747 n=6
xstate - node (v14.15.1, x64)
Memory used 536,696k (± 0.00%) 535,240k (± 0.01%) -1,456k (- 0.27%) 535,189k 535,296k p=0.005 n=6
Parse Time 4.17s (± 1.70%) 4.41s (± 0.45%) +0.24s (+ 5.71%) 4.38s 4.43s p=0.005 n=6
Bind Time 1.68s (± 2.39%) 1.79s (± 0.71%) +0.11s (+ 6.23%) 1.78s 1.81s p=0.005 n=6
Check Time 3.16s (± 0.47%) 3.15s (± 0.52%) ~ 3.13s 3.17s p=0.745 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.12s (± 0.45%) 9.45s (± 0.38%) +0.33s (+ 3.62%) 9.39s 9.49s p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53144 6
Baseline main 6

TSServer

Comparison Report - main..53144
Metric main 53144 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,385ms (± 0.51%) 2,372ms (± 0.66%) ~ 2,348ms 2,397ms p=0.173 n=6
Req 2 - geterr 5,348ms (± 0.31%) 5,351ms (± 0.75%) ~ 5,319ms 5,426ms p=0.810 n=6
Req 3 - references 336ms (± 0.58%) 326ms (± 1.50%) -10ms (- 2.93%) 321ms 333ms p=0.006 n=6
Req 4 - navto 280ms (± 0.32%) 283ms (± 0.86%) ~ 279ms 285ms p=0.061 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 82ms (± 0.63%) 81ms (± 7.72%) ~ 73ms 89ms p=0.368 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,515ms (± 0.32%) 2,500ms (± 0.44%) -14ms (- 0.57%) 2,484ms 2,512ms p=0.045 n=6
Req 2 - geterr 4,004ms (± 0.53%) 4,009ms (± 0.24%) ~ 3,997ms 4,023ms p=0.689 n=6
Req 3 - references 350ms (± 1.19%) 347ms (± 0.91%) ~ 343ms 351ms p=0.258 n=6
Req 4 - navto 294ms (± 1.11%) 293ms (± 1.00%) ~ 291ms 299ms p=1.000 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 80ms (± 5.64%) 78ms (± 4.55%) ~ 74ms 82ms p=0.413 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,045ms (± 0.56%) 3,139ms (± 0.35%) +94ms (+ 3.09%) 3,125ms 3,156ms p=0.005 n=6
Req 2 - geterr 1,598ms (± 1.01%) 1,610ms (± 0.71%) ~ 1,592ms 1,620ms p=0.230 n=6
Req 3 - references 106ms (± 1.69%) 105ms (± 0.93%) ~ 104ms 106ms p=0.508 n=6
Req 4 - navto 360ms (± 0.60%) 361ms (± 0.49%) ~ 357ms 362ms p=0.490 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 429ms (± 0.60%) 427ms (± 0.82%) ~ 423ms 432ms p=0.225 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,505ms (± 0.97%) 2,501ms (± 0.65%) ~ 2,479ms 2,519ms p=0.936 n=6
Req 2 - geterr 5,744ms (± 0.57%) 5,756ms (± 0.66%) ~ 5,704ms 5,801ms p=0.810 n=6
Req 3 - references 345ms (± 0.87%) 343ms (± 0.62%) ~ 340ms 345ms p=0.808 n=6
Req 4 - navto 277ms (± 0.84%) 279ms (± 0.78%) ~ 276ms 281ms p=0.466 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 74ms (± 0.70%) 87ms (± 9.27%) +13ms (+17.65%) 77ms 96ms p=0.004 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,682ms (± 0.45%) 2,649ms (± 0.88%) -33ms (- 1.22%) 2,618ms 2,681ms p=0.020 n=6
Req 2 - geterr 4,361ms (± 0.71%) 4,357ms (± 0.33%) ~ 4,341ms 4,377ms p=0.689 n=6
Req 3 - references 359ms (± 0.73%) 359ms (± 0.65%) ~ 356ms 362ms p=0.686 n=6
Req 4 - navto 291ms (± 0.68%) 288ms (± 0.57%) -3ms (- 1.09%) 285ms 289ms p=0.019 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 82ms (± 7.68%) 74ms (± 3.36%) 🟩-7ms (- 8.98%) 72ms 78ms p=0.029 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,167ms (± 0.42%) 3,295ms (± 0.55%) +128ms (+ 4.05%) 3,271ms 3,320ms p=0.005 n=6
Req 2 - geterr 1,740ms (± 0.66%) 1,741ms (± 0.94%) ~ 1,714ms 1,757ms p=0.810 n=6
Req 3 - references 116ms (± 1.77%) 112ms (± 1.34%) 🟩-4ms (- 3.44%) 111ms 114ms p=0.007 n=6
Req 4 - navto 343ms (± 0.95%) 346ms (± 0.34%) ~ 344ms 347ms p=0.090 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 432ms (± 0.84%) 435ms (± 0.92%) ~ 428ms 438ms p=0.193 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,587ms (± 0.91%) 2,564ms (± 0.42%) ~ 2,553ms 2,580ms p=0.065 n=6
Req 2 - geterr 6,117ms (± 0.53%) 6,072ms (± 0.63%) ~ 6,033ms 6,134ms p=0.066 n=6
Req 3 - references 365ms (± 1.01%) 359ms (± 0.72%) -6ms (- 1.69%) 355ms 362ms p=0.018 n=6
Req 4 - navto 280ms (± 1.55%) 276ms (± 0.77%) ~ 274ms 280ms p=0.121 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 92ms (± 9.27%) 102ms (± 0.74%) ~ 101ms 103ms p=0.164 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,816ms (± 0.26%) 2,808ms (± 0.20%) -9ms (- 0.31%) 2,801ms 2,818ms p=0.024 n=6
Req 2 - geterr 4,494ms (± 2.16%) 4,595ms (± 2.45%) ~ 4,434ms 4,693ms p=0.230 n=6
Req 3 - references 419ms (± 5.26%) 370ms (± 1.01%) 🟩-49ms (-11.69%) 366ms 375ms p=0.010 n=6
Req 4 - navto 289ms (± 0.80%) 293ms (± 1.36%) ~ 289ms 298ms p=0.123 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 95ms (± 7.29%) 83ms (± 2.07%) ~ 81ms 85ms p=0.053 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,489ms (± 0.18%) 3,623ms (± 0.63%) +134ms (+ 3.84%) 3,582ms 3,645ms p=0.005 n=6
Req 2 - geterr 1,851ms (± 0.27%) 1,845ms (± 0.63%) ~ 1,826ms 1,857ms p=0.470 n=6
Req 3 - references 125ms (± 0.67%) 125ms (± 1.63%) ~ 123ms 129ms p=0.788 n=6
Req 4 - navto 375ms (± 0.58%) 375ms (± 1.27%) ~ 371ms 382ms p=0.807 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 449ms (± 1.52%) 448ms (± 2.17%) ~ 433ms 460ms p=0.932 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53144 6
Baseline main 6

Startup

Comparison Report - main..53144
Metric main 53144 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.18ms (± 0.20%) 141.10ms (± 0.17%) ~ 140.50ms 143.97ms p=0.147 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 225.78ms (± 0.18%) 225.78ms (± 0.13%) ~ 224.92ms 229.12ms p=0.070 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.02ms (± 0.19%) 227.91ms (± 0.19%) -0.11ms (- 0.05%) 226.96ms 238.42ms p=0.024 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 208.63ms (± 0.16%) 208.73ms (± 0.19%) +0.09ms (+ 0.04%) 207.86ms 214.57ms p=0.002 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53144 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

Eek, it's worse?

@sandersn
Copy link
Member Author

sandersn commented Mar 8, 2023

--predictable gives different results, but they are very small, so I don't want to bet that the normal perf results are wrong and my --predictable local run is right.

@sandersn sandersn closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandersn @DanielRosenwasser @typescript-bot @jakebailey