Fixed binding element types coming from the out of tuple bounds under `noUncheckedIndexedAccess` #52318

Andarist · 2023-01-19T23:43:33Z

… `noUncheckedIndexedAccess`

RyanCavanaugh · 2023-01-20T00:06:41Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 93e5324. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 93e5324. You can monitor the build here.

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 93e5324. You can monitor the build here.

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 93e5324. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 93e5324. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 93e5324. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:06:44Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 93e5324. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T00:19:40Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52318/merge:

Everything looks good!

typescript-bot · 2023-01-20T00:19:43Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52318/merge:

Everything looks good!

typescript-bot · 2023-01-20T00:26:52Z

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-20T01:39:29Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52318/merge:

Something interesting changed - please have a look.

Details

nocodb/nocodb

⚠️ Note that built also had errors ⚠️

Req #8090 - completionInfo
    at getMembersOfSymbol (/typescript-main/built/local/tsserver.js:56817:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-main/built/local/tsserver.js:61584:11)
    at getTypeFromTypeNodeWorker (/typescript-main/built/local/tsserver.js:61952:16)
    at getTypeFromTypeNode (/typescript-main/built/local/tsserver.js:61878:41)
    at map (/typescript-main/built/local/tsserver.js:2940:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-main/built/local/tsserver.js:59405:12)
    at getTypeFromClassOrInterfaceReference (/typescript-main/built/local/tsserver.js:59090:92)
    at getTypeReferenceType (/typescript-main/built/local/tsserver.js:59216:14)
    at getTypeFromTypeReference (/typescript-main/built/local/tsserver.js:59392:18)
    at getTypeParametersForTypeReference (/typescript-main/built/local/tsserver.js:78668:18)
    at getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:78712:28)
    at Object.getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:47484:22)
    at getConstraintOfTypeArgumentProperty (/typescript-main/built/local/tsserver.js:153463:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-main/built/local/tsserver.js:152678:35)
    at tryGetGlobalSymbols (/typescript-main/built/local/tsserver.js:152321:20)
    at getCompletionData (/typescript-main/built/local/tsserver.js:152088:10)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:150377:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:137520:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:180032:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:178431:43)
    at /typescript-main/built/local/tsserver.js:180796:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:180788:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:180796:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:180838:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:182289:14)

Req #8090 - completionInfo
    at getMembersOfSymbol (/typescript-52318/built/local/tsserver.js:56817:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-52318/built/local/tsserver.js:61584:11)
    at getTypeFromTypeNodeWorker (/typescript-52318/built/local/tsserver.js:61952:16)
    at getTypeFromTypeNode (/typescript-52318/built/local/tsserver.js:61878:41)
    at map (/typescript-52318/built/local/tsserver.js:2940:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-52318/built/local/tsserver.js:59405:12)
    at getTypeFromClassOrInterfaceReference (/typescript-52318/built/local/tsserver.js:59090:92)
    at getTypeReferenceType (/typescript-52318/built/local/tsserver.js:59216:14)
    at getTypeFromTypeReference (/typescript-52318/built/local/tsserver.js:59392:18)
    at getTypeParametersForTypeReference (/typescript-52318/built/local/tsserver.js:78676:18)
    at getTypeArgumentConstraint (/typescript-52318/built/local/tsserver.js:78720:28)
    at Object.getTypeArgumentConstraint (/typescript-52318/built/local/tsserver.js:47484:22)
    at getConstraintOfTypeArgumentProperty (/typescript-52318/built/local/tsserver.js:153471:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-52318/built/local/tsserver.js:152686:35)
    at tryGetGlobalSymbols (/typescript-52318/built/local/tsserver.js:152329:20)
    at getCompletionData (/typescript-52318/built/local/tsserver.js:152096:10)
    at Object.getCompletionsAtPosition (/typescript-52318/built/local/tsserver.js:150385:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52318/built/local/tsserver.js:137528:35)
    at IOSession.getCompletions (/typescript-52318/built/local/tsserver.js:180040:54)
    at completionInfo (/typescript-52318/built/local/tsserver.js:178439:43)
    at /typescript-52318/built/local/tsserver.js:180804:69
    at IOSession.executeWithRequestId (/typescript-52318/built/local/tsserver.js:180796:14)
    at IOSession.executeCommand (/typescript-52318/built/local/tsserver.js:180804:29)
    at IOSession.onMessage (/typescript-52318/built/local/tsserver.js:180846:51)
    at Interface.<anonymous> (/typescript-52318/built/local/tsserver.js:182297:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/nocodb.nocodb.rawError.txt in the artifact folder

Last few requests

{"seq":8087,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/packages/nocodb/src/lib/db/sql-client/lib/snowflake/SnowflakeClient.ts","line":1815,"offset":6,"entryNames":["@abstract"]}}
{"seq":8088,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/nocodb/src/lib/db/sql-client/lib/snowflake/SnowflakeClient.ts","line":1816,"offset":6}}
{"seq":8089,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/nocodb/src/lib/db/sql-client/lib/snowflake/SnowflakeClient.ts","line":1817,"offset":6}}
{"seq":8090,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/nocodb/src/lib/db/sql-client/lib/snowflake/SnowflakeClient.ts","line":1817,"offset":36,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}

Repro Steps

git clone https://github.com/nocodb/nocodb --recurse-submodules
In dir nocodb, run git reset --hard a4a21857efe15fd5536c29909388fcde37b49b55
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir nocodb, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
2. In dir nocodb/scripts/pkg-executable, run npm install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
3. In dir nocodb/tests/playwright, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
Back in the initial folder, download RepoResults2/nocodb.nocodb.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./nocodb ./nocodb.nocodb.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typescript-bot · 2023-01-20T01:49:33Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52318/merge:

Everything looks good!

typescript-bot · 2023-01-20T01:55:50Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52318

_Metric	_main	₅₂₃₁₈	_Delta	_Best	_Worst
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{358,881k (± 0.02%)}	_{358,833k (± 0.01%)}	_{-48k (- 0.01%)}	_358,781k	_358,909k
_{Parse Time}	_{3.90s (± 0.83%)}	_{3.90s (± 1.18%)}	_{+0.00s (+ 0.09%)}	_3.86s	_3.95s
_{Bind Time}	_{1.17s (± 1.20%)}	_{1.18s (± 0.66%)}	_{+0.01s (+ 0.71%)}	_1.17s	_1.19s
_{Check Time}	_{8.85s (± 0.43%)}	_{8.85s (± 0.45%)}	_{+0.00s (+ 0.02%)}	_8.79s	_8.91s
_{Emit Time}	_{7.62s (± 0.42%)}	_{7.61s (± 0.85%)}	_{-0.01s (- 0.11%)}	_7.49s	_7.67s
_{Total Time}	_{21.55s (± 0.25%)}	_{21.55s (± 0.40%)}	_{+0.01s (+ 0.02%)}	_21.40s	_21.62s
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,457k (± 1.17%)}	_{194,381k (± 1.47%)}	_{+924k (+ 0.48%)}	_192,517k	_198,101k
_{Parse Time}	_{1.62s (± 1.63%)}	_{1.63s (± 1.33%)}	_{+0.01s (+ 0.47%)}	_1.60s	_1.65s
_{Bind Time}	_{0.79s (± 0.65%)}	_{0.79s (± 0.74%)}	_{+0.00s (+ 0.07%)}	_0.79s	_0.80s
_{Check Time}	_{9.64s (± 0.65%)}	_{9.64s (± 0.78%)}	_{+0.00s (+ 0.03%)}	_9.56s	_9.77s
_{Emit Time}	_{2.82s (± 0.95%)}	_{2.80s (± 0.56%)}	_{-0.02s (- 0.70%)}	_2.78s	_2.82s
_{Total Time}	_{14.87s (± 0.58%)}	_{14.86s (± 0.64%)}	_{-0.01s (- 0.09%)}	_14.75s	_14.98s
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,877k (± 0.00%)}	_{343,878k (± 0.01%)}	_{+1k (+ 0.00%)}	_343,844k	_343,901k
_{Parse Time}	_{2.93s (± 1.00%)}	_{2.94s (± 0.76%)}	_{+0.01s (+ 0.34%)}	_2.89s	_2.95s
_{Bind Time}	_{1.04s (± 1.18%)}	_{1.05s (± 0.95%)}	_{+0.01s (+ 0.80%)}	_1.04s	_1.06s
_{Check Time}	_{7.24s (± 0.45%)}	_{7.27s (± 0.56%)}	_{+0.03s (+ 0.44%)}	_7.21s	_7.33s
_{Emit Time}	_{4.35s (± 0.62%)}	_{4.33s (± 0.65%)}	_{-0.03s (- 0.61%)}	_4.29s	_4.37s
_{Total Time}	_{15.56s (± 0.28%)}	_{15.58s (± 0.37%)}	_{+0.02s (+ 0.15%)}	_15.50s	_15.67s
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,264k (± 0.00%)}	_{300,278k (± 0.01%)}	_{+14k (+ 0.00%)}	_300,240k	_300,304k
_{Parse Time}	_{2.25s (± 1.64%)}	_{2.23s (± 1.60%)}	_{-0.02s (- 0.92%)}	_2.20s	_2.28s
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.17s (± 0.63%)}	_{-0.01s (- 0.45%)}	_1.17s	_1.19s
_{Check Time}	_{6.85s (± 0.38%)}	_{6.84s (± 0.52%)}	_{-0.01s (- 0.15%)}	_6.79s	_6.90s
_{Emit Time}	_{3.95s (± 0.49%)}	_{3.91s (± 0.68%)}	_{-0.04s (- 0.96%)}	_3.88s	_3.95s
_{Total Time}	_{14.23s (± 0.36%)}	_{14.17s (± 0.41%)}	_{-0.06s (- 0.45%)}	_14.09s	_14.26s
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,118k (± 0.00%)}	_{476,081k (± 0.00%)}	_{-37k (- 0.01%)}	_476,055k	_476,105k
_{Parse Time}	_{3.46s (± 0.70%)}	_{3.46s (± 1.14%)}	_{+0.00s (+ 0.05%)}	_3.41s	_3.52s
_{Bind Time}	_{0.96s (± 0.63%)}	_{0.96s (± 1.29%)}	_{-0.00s (- 0.42%)}	_0.94s	_0.98s
_{Check Time}	_{17.01s (± 0.24%)}	_{16.95s (± 0.52%)}	_{-0.05s (- 0.31%)}	_16.80s	_17.03s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.42s (± 0.25%)}	_{21.37s (± 0.38%)}	_{-0.05s (- 0.22%)}	_21.26s	_21.47s
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{546,712k (± 0.02%)}	_{546,758k (± 0.01%)}	_{+47k (+ 0.01%)}	_546,723k	_546,831k
_{Parse Time}	_{4.40s (± 0.49%)}	_{4.41s (± 0.54%)}	_{+0.02s (+ 0.38%)}	_4.37s	_4.44s
_{Bind Time}	_{1.69s (± 0.91%)}	_{1.71s (± 0.62%)}	_{+0.02s (+ 1.15%)}	_1.70s	_1.73s
_{Check Time}	_{2.73s (± 0.86%)}	_{2.73s (± 1.01%)}	_{+0.01s (+ 0.21%)}	_2.69s	_2.77s
_{Emit Time}	_{0.08s (± 0.10%)}	_{0.08s (± 0.17%)}	_{-0.00s (- 0.03%)}	_0.08s	_0.08s
_{Total Time}	_{8.89s (± 0.48%)}	_{8.94s (± 0.37%)}	_{+0.05s (+ 0.51%)}	_8.91s	_8.98s
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,218k (± 0.01%)}	_{358,223k (± 0.01%)}	_{+5k (+ 0.00%)}	_358,195k	_358,267k
_{Parse Time}	_{4.12s (± 0.39%)}	_{4.13s (± 0.33%)}	_{+0.01s (+ 0.34%)}	_4.11s	_4.15s
_{Bind Time}	_{1.24s (± 0.58%)}	_{1.24s (± 0.33%)}	_{+0.00s (+ 0.37%)}	_1.24s	_1.25s
_{Check Time}	_{9.49s (± 0.25%)}	_{9.48s (± 0.36%)}	_{-0.01s (- 0.14%)}	_9.44s	_9.53s
_{Emit Time}	_{8.03s (± 0.31%)}	_{8.07s (± 0.43%)}	_{+0.04s (+ 0.49%)}	_8.03s	_8.13s
_{Total Time}	_{22.88s (± 0.16%)}	_{22.92s (± 0.32%)}	_{+0.04s (+ 0.17%)}	_22.83s	_23.04s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,277k (± 0.05%)}	_{194,248k (± 0.04%)}	_{-29k (- 0.02%)}	_194,144k	_194,353k
_{Parse Time}	_{1.80s (± 0.64%)}	_{1.79s (± 0.44%)}	_{-0.00s (- 0.12%)}	_1.79s	_1.81s
_{Bind Time}	_{0.84s (± 0.23%)}	_{0.84s (± 0.77%)}	_{+0.01s (+ 0.66%)}	_0.84s	_0.85s
_{Check Time}	_{10.34s (± 0.81%)}	_{10.33s (± 0.36%)}	_{-0.01s (- 0.14%)}	_10.30s	_10.40s
_{Emit Time}	_{3.04s (± 0.34%)}	_{3.07s (± 0.77%)}	_{+0.03s (+ 1.00%)}	_3.04s	_3.10s
_{Total Time}	_{16.01s (± 0.53%)}	_{16.03s (± 0.32%)}	_{+0.02s (+ 0.11%)}	_15.98s	_16.10s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,227k (± 0.00%)}	_{343,211k (± 0.01%)}	_{-16k (- 0.00%)}	_343,162k	_343,260k
_{Parse Time}	_{3.11s (± 0.87%)}	_{3.11s (± 0.72%)}	_{-0.01s (- 0.18%)}	_3.07s	_3.13s
_{Bind Time}	_{1.10s (± 0.65%)}	_{1.10s (± 0.10%)}	_{-0.01s (- 0.57%)}	_1.10s	_1.10s
_{Check Time}	_{7.87s (± 0.16%)}	_{7.89s (± 0.32%)}	_{+0.03s (+ 0.35%)}	_7.86s	_7.92s
_{Emit Time}	_{4.53s (± 0.48%)}	_{4.57s (± 0.24%)}	_{+0.04s (+ 0.84%)}	_4.56s	_4.59s
_{Total Time}	_{16.62s (± 0.22%)}	_{16.67s (± 0.17%)}	_{+0.05s (+ 0.30%)}	_16.64s	_16.72s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,618k (± 0.01%)}	_{299,619k (± 0.01%)}	_{+1k (+ 0.00%)}	_299,589k	_299,645k
_{Parse Time}	_{2.43s (± 0.86%)}	_{2.45s (± 0.88%)}	_{+0.02s (+ 0.86%)}	_2.42s	_2.48s
_{Bind Time}	_{1.27s (± 0.40%)}	_{1.26s (± 0.77%)}	_{-0.00s (- 0.23%)}	_1.25s	_1.27s
_{Check Time}	_{7.45s (± 0.56%)}	_{7.45s (± 0.48%)}	_{-0.00s (- 0.01%)}	_7.41s	_7.50s
_{Emit Time}	_{4.24s (± 0.89%)}	_{4.25s (± 0.99%)}	_{+0.00s (+ 0.02%)}	_4.19s	_4.29s
_{Total Time}	_{15.40s (± 0.44%)}	_{15.42s (± 0.31%)}	_{+0.02s (+ 0.12%)}	_15.33s	_15.46s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,331k (± 0.01%)}	_{475,336k (± 0.00%)}	_{+5k (+ 0.00%)}	_475,318k	_475,358k
_{Parse Time}	_{3.64s (± 0.46%)}	_{3.63s (± 0.25%)}	_{-0.00s (- 0.10%)}	_3.62s	_3.65s
_{Bind Time}	_{1.00s (± 0.48%)}	_{1.01s (± 0.98%)}	_{+0.00s (+ 0.23%)}	_0.99s	_1.02s
_{Check Time}	_{17.99s (± 0.40%)}	_{17.99s (± 0.33%)}	_{+0.00s (+ 0.01%)}	_17.93s	_18.08s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.63s (± 0.34%)}	_{22.63s (± 0.29%)}	_{+0.00s (+ 0.02%)}	_22.56s	_22.72s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{544,489k (± 0.02%)}	_{544,527k (± 0.03%)}	_{+38k (+ 0.01%)}	_544,347k	_544,798k
_{Parse Time}	_{4.58s (± 0.63%)}	_{4.56s (± 0.19%)}	_{-0.02s (- 0.36%)}	_4.55s	_4.57s
_{Bind Time}	_{1.78s (± 0.45%)}	_{1.78s (± 0.20%)}	_{+0.00s (+ 0.06%)}	_1.78s	_1.79s
_{Check Time}	_{2.95s (± 0.49%)}	_{2.94s (± 0.34%)}	_{-0.01s (- 0.48%)}	_2.93s	_2.95s
_{Emit Time}	_{0.09s (± 0.15%)}	_{0.09s (± 0.22%)}	_{-0.00s (- 0.03%)}	_0.09s	_0.09s
_{Total Time}	_{9.40s (± 0.42%)}	_{9.37s (± 0.15%)}	_{-0.03s (- 0.35%)}	_9.35s	_9.39s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{351,804k (± 0.01%)}	_{351,786k (± 0.00%)}	_{-18k (- 0.01%)}	_351,765k	_351,804k
_{Parse Time}	_{4.16s (± 0.52%)}	_{4.15s (± 0.40%)}	_{-0.00s (- 0.11%)}	_4.12s	_4.17s
_{Bind Time}	_{1.26s (± 0.52%)}	_{1.26s (± 0.52%)}	_{-0.00s (- 0.16%)}	_1.25s	_1.27s
_{Check Time}	_{9.76s (± 0.57%)}	_{9.76s (± 0.52%)}	_{+0.01s (+ 0.07%)}	_9.72s	_9.85s
_{Emit Time}	_{8.38s (± 0.66%)}	_{8.39s (± 0.49%)}	_{+0.01s (+ 0.13%)}	_8.34s	_8.46s
_{Total Time}	_{23.56s (± 0.35%)}	_{23.57s (± 0.34%)}	_{+0.01s (+ 0.06%)}	_23.48s	_23.68s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,407k (± 0.89%)}	_{189,276k (± 0.02%)}	_{-1,130k (- 0.59%)}	_189,235k	_189,311k
_{Parse Time}	_{1.84s (± 0.60%)}	_{1.84s (± 0.80%)}	_{+0.00s (+ 0.25%)}	_1.82s	_1.86s
_{Bind Time}	_{0.87s (± 0.85%)}	_{0.86s (± 0.52%)}	_{-0.01s (- 0.70%)}	_0.86s	_0.87s
_{Check Time}	_{10.36s (± 0.30%)}	_{10.34s (± 0.38%)}	_{-0.02s (- 0.22%)}	_10.29s	_10.39s
_{Emit Time}	_{3.13s (± 0.48%)}	_{3.15s (± 0.70%)}	_{+0.02s (+ 0.60%)}	_3.11s	_3.17s
_{Total Time}	_{16.20s (± 0.20%)}	_{16.20s (± 0.31%)}	_{-0.00s (- 0.03%)}	_16.13s	_16.27s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{337,941k (± 0.01%)}	_{337,993k (± 0.02%)}	_{+52k (+ 0.02%)}	_337,944k	_338,067k
_{Parse Time}	_{3.24s (± 0.51%)}	_{3.23s (± 0.66%)}	_{-0.01s (- 0.27%)}	_3.21s	_3.27s
_{Bind Time}	_{1.12s (± 0.53%)}	_{1.12s (± 0.77%)}	_{-0.00s (- 0.21%)}	_1.11s	_1.13s
_{Check Time}	_{8.18s (± 0.45%)}	_{8.17s (± 0.54%)}	_{-0.01s (- 0.17%)}	_8.12s	_8.25s
_{Emit Time}	_{4.79s (± 0.81%)}	_{4.81s (± 0.60%)}	_{+0.02s (+ 0.38%)}	_4.78s	_4.85s
_{Total Time}	_{17.34s (± 0.41%)}	_{17.33s (± 0.20%)}	_{-0.00s (- 0.03%)}	_17.28s	_17.38s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,473k (± 0.01%)}	_{294,483k (± 0.01%)}	_{+10k (+ 0.00%)}	_294,456k	_294,512k
_{Parse Time}	_{2.68s (± 1.33%)}	_{2.70s (± 1.04%)}	_{+0.02s (+ 0.83%)}	_2.66s	_2.73s
_{Bind Time}	_{1.11s (± 0.54%)}	_{1.12s (± 1.81%)}	_{+0.01s (+ 1.02%)}	_1.11s	_1.16s
_{Check Time}	_{7.77s (± 0.50%)}	_{7.76s (± 0.52%)}	_{-0.01s (- 0.12%)}	_7.69s	_7.80s
_{Emit Time}	_{4.57s (± 0.81%)}	_{4.61s (± 1.19%)}	_{+0.05s (+ 0.99%)}	_4.55s	_4.70s
_{Total Time}	_{16.11s (± 0.29%)}	_{16.19s (± 0.42%)}	_{+0.07s (+ 0.45%)}	_16.10s	_16.26s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{470,834k (± 0.00%)}	_{470,831k (± 0.00%)}	_{-3k (- 0.00%)}	_470,816k	_470,862k
_{Parse Time}	_{3.83s (± 0.87%)}	_{3.84s (± 0.58%)}	_{+0.01s (+ 0.33%)}	_3.82s	_3.88s
_{Bind Time}	_{1.02s (± 0.64%)}	_{1.02s (± 0.50%)}	_{+0.00s (+ 0.07%)}	_1.01s	_1.03s
_{Check Time}	_{18.93s (± 0.55%)}	_{18.94s (± 0.16%)}	_{+0.01s (+ 0.07%)}	_18.91s	_18.99s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.78s (± 0.56%)}	_{23.81s (± 0.17%)}	_{+0.03s (+ 0.11%)}	_23.76s	_23.87s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{532,469k (± 0.01%)}	_{532,441k (± 0.00%)}	_{-27k (- 0.01%)}	_532,423k	_532,465k
_{Parse Time}	_{5.00s (± 1.19%)}	_{5.00s (± 0.88%)}	_{-0.00s (- 0.03%)}	_4.93s	_5.06s
_{Bind Time}	_{1.67s (± 0.57%)}	_{1.67s (± 0.46%)}	_{+0.01s (+ 0.37%)}	_1.67s	_1.69s
_{Check Time}	_{3.10s (± 0.83%)}	_{3.09s (± 0.48%)}	_{-0.00s (- 0.09%)}	_3.07s	_3.11s
_{Emit Time}	_{0.10s (± 0.16%)}	_{0.10s (± 0.16%)}	_{+0.00s (+ 0.07%)}	_0.10s	_0.10s
_{Total Time}	_{9.87s (± 0.80%)}	_{9.87s (± 0.47%)}	_{-0.00s (- 0.02%)}	_9.79s	_9.93s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₁₈	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52318

_Metric	_main	₅₂₃₁₈	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,311ms (± 8.00%)}	_{2,235ms (± 7.19%)}	_{🟩-76ms (- 3.29%)}	_2,134ms	_2,558ms
_{Req 2 - geterr}	_{5,066ms (± 8.25%)}	_{4,861ms (± 6.81%)}	_{🟩-204ms (- 4.04%)}	_4,692ms	_5,535ms
_{Req 3 - references}	_{352ms (± 7.54%)}	_{332ms (± 8.10%)}	_{🟩-20ms (- 5.62%)}	_309ms	_384ms
_{Req 4 - navto}	_{262ms (± 7.83%)}	_{256ms (± 7.97%)}	_{-7ms (- 2.52%)}	_243ms	_296ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{71ms (±12.05%)}	_{67ms (± 7.28%)}	_{🟩-3ms (- 4.81%)}	_61ms	_72ms
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,715ms (± 1.71%)}	_{2,694ms (± 0.46%)}	_{-21ms (- 0.79%)}	_2,674ms	_2,703ms
_{Req 2 - geterr}	_{3,971ms (± 0.67%)}	_{3,972ms (± 0.36%)}	_{+1ms (+ 0.03%)}	_3,956ms	_3,996ms
_{Req 3 - references}	_{364ms (± 0.87%)}	_{366ms (± 0.73%)}	_{+2ms (+ 0.63%)}	_363ms	_371ms
_{Req 4 - navto}	_{292ms (± 1.22%)}	_{292ms (± 0.98%)}	_{+1ms (+ 0.24%)}	_287ms	_295ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{80ms (± 0.91%)}	_{81ms (± 1.98%)}	_{+1ms (+ 1.18%)}	_78ms	_83ms
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,317ms (± 0.52%)}	_{3,315ms (± 0.94%)}	_{-2ms (- 0.06%)}	_3,288ms	_3,367ms
_{Req 2 - geterr}	_{1,395ms (± 1.07%)}	_{1,396ms (± 1.13%)}	_{+0ms (+ 0.03%)}	_1,372ms	_1,414ms
_{Req 3 - references}	_{245ms (± 1.16%)}	_{242ms (± 1.31%)}	_{-2ms (- 0.94%)}	_239ms	_248ms
_{Req 4 - navto}	_{350ms (± 0.66%)}	_{351ms (± 1.37%)}	_{+0ms (+ 0.14%)}	_342ms	_357ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{440ms (± 0.83%)}	_{434ms (± 1.91%)}	_{-6ms (- 1.35%)}	_427ms	_447ms
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,669ms (± 5.37%)}	_{2,743ms (± 0.65%)}	_{+74ms (+ 2.79%)}	_2,711ms	_2,760ms
_{Req 2 - geterr}	_{5,624ms (± 5.26%)}	_{5,778ms (± 0.76%)}	_{+154ms (+ 2.74%)}	_5,715ms	_5,846ms
_{Req 3 - references}	_{361ms (± 5.11%)}	_{371ms (± 0.49%)}	_{+10ms (+ 2.77%)}	_368ms	_374ms
_{Req 4 - navto}	_{261ms (± 5.23%)}	_{269ms (± 0.46%)}	_{+8ms (+ 3.08%)}	_268ms	_271ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{252ms (±35.70%)}	_{294ms (± 1.66%)}	_{+42ms (+16.86%)}	_288ms	_299ms
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,899ms (± 0.47%)}	_{2,898ms (± 0.31%)}	_{-1ms (- 0.04%)}	_2,887ms	_2,911ms
_{Req 2 - geterr}	_{4,299ms (± 0.39%)}	_{4,293ms (± 0.27%)}	_{-7ms (- 0.16%)}	_4,281ms	_4,311ms
_{Req 3 - references}	_{380ms (± 0.75%)}	_{380ms (± 0.58%)}	_{-0ms (- 0.02%)}	_376ms	_382ms
_{Req 4 - navto}	_{296ms (± 1.03%)}	_{298ms (± 0.48%)}	_{+2ms (+ 0.60%)}	_296ms	_300ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{83ms (± 7.77%)}	_{82ms (± 6.01%)}	_{-1ms (- 0.87%)}	_77ms	_89ms
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,447ms (± 0.59%)}	_{3,463ms (± 0.18%)}	_{+16ms (+ 0.47%)}	_3,455ms	_3,470ms
_{Req 2 - geterr}	_{1,655ms (± 4.11%)}	_{1,606ms (± 5.14%)}	_{-49ms (- 2.94%)}	_1,502ms	_1,716ms
_{Req 3 - references}	_{154ms (±45.42%)}	_{200ms (±35.72%)}	_{+46ms (+29.58%)}	_110ms	_274ms
_{Req 4 - navto}	_{327ms (± 0.62%)}	_{328ms (± 0.78%)}	_{+0ms (+ 0.08%)}	_325ms	_333ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{475ms (± 2.33%)}	_{476ms (± 0.54%)}	_{+1ms (+ 0.25%)}	_473ms	_480ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,841ms (± 0.26%)}	_{2,849ms (± 0.69%)}	_{+9ms (+ 0.31%)}	_2,822ms	_2,880ms
_{Req 2 - geterr}	_{6,146ms (± 0.47%)}	_{6,145ms (± 0.24%)}	_{-0ms (- 0.00%)}	_6,118ms	_6,160ms
_{Req 3 - references}	_{385ms (± 0.80%)}	_{389ms (± 0.76%)}	_{+4ms (+ 1.03%)}	_385ms	_392ms
_{Req 4 - navto}	_{278ms (± 0.73%)}	_{279ms (± 0.63%)}	_{+1ms (+ 0.23%)}	_277ms	_282ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{76ms (± 4.01%)}	_{76ms (± 3.41%)}	_{-0ms (- 0.41%)}	_71ms	_79ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,998ms (± 0.33%)}	_{3,001ms (± 0.65%)}	_{+3ms (+ 0.10%)}	_2,974ms	_3,029ms
_{Req 2 - geterr}	_{4,609ms (± 0.19%)}	_{4,599ms (± 0.38%)}	_{-10ms (- 0.22%)}	_4,575ms	_4,628ms
_{Req 3 - references}	_{410ms (± 0.78%)}	_{409ms (± 0.98%)}	_{-1ms (- 0.17%)}	_403ms	_415ms
_{Req 4 - navto}	_{298ms (± 0.57%)}	_{299ms (± 0.83%)}	_{+1ms (+ 0.32%)}	_296ms	_302ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{83ms (± 4.57%)}	_{85ms (± 3.60%)}	_{+1ms (+ 1.63%)}	_79ms	_88ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,774ms (± 0.55%)}	_{3,802ms (± 0.64%)}	_{+28ms (+ 0.74%)}	_3,781ms	_3,846ms
_{Req 2 - geterr}	_{1,465ms (± 1.03%)}	_{1,465ms (± 0.85%)}	_{-0ms (- 0.02%)}	_1,450ms	_1,479ms
_{Req 3 - references}	_{129ms (± 2.64%)}	_{129ms (± 2.06%)}	_{-0ms (- 0.23%)}	_126ms	_133ms
_{Req 4 - navto}	_{365ms (± 0.56%)}	_{364ms (± 1.73%)}	_{-1ms (- 0.18%)}	_356ms	_373ms
_{Req 5 - completionInfo count}	_{3,159 (± 0.00%)}	_{3,159 (± 0.00%)}	_{0 ( 0.00%)}	_3,159	_3,159
_{Req 5 - completionInfo}	_{512ms (± 1.88%)}	_{505ms (± 2.72%)}	_{-8ms (- 1.50%)}	_487ms	_527ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₁₈	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52318

_Metric	_main	₅₂₃₁₈	_Delta	_Best	_Worst
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.09ms (± 0.27%)}	_{141.77ms (± 0.21%)}	_{+0.68ms (+ 0.48%)}	_140.78ms	_145.48ms
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{233.17ms (± 0.15%)}	_{233.86ms (± 0.21%)}	_{+0.69ms (+ 0.29%)}	_232.32ms	_240.81ms
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{236.28ms (± 0.16%)}	_{236.54ms (± 0.14%)}	_{+0.26ms (+ 0.11%)}	_235.41ms	_240.19ms
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{217.14ms (± 0.22%)}	_{218.48ms (± 0.19%)}	_{+1.34ms (+ 0.62%)}	_217.05ms	_224.43ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₁₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Andarist · 2023-01-20T08:00:29Z

@RyanCavanaugh do you happen to know if this one is just a flake or is it something that I should look into?

sandersn

Looks good, but can you reorder the oobounds calculation as requested?

src/compiler/checker.ts

…UncheckedIndexedAccess` check

Fixed binding element types coming from the out of tuple bounds under…

93e5324

… `noUncheckedIndexedAccess`

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 19, 2023

sandersn requested changes Feb 1, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

sandersn self-assigned this Feb 1, 2023

Move the getEndElementCount call into a branch guarded with the `no…

447a098

…UncheckedIndexedAccess` check

Andarist requested a review from sandersn February 1, 2023 20:46

sandersn approved these changes Feb 7, 2023

View reviewed changes

sandersn merged commit 76c23e4 into microsoft:main Feb 7, 2023

Andarist deleted the fix/52302 branch February 7, 2023 14:50

Fixed binding element types coming from the out of tuple bounds under noUncheckedIndexedAccess #52318

Fixed binding element types coming from the out of tuple bounds under noUncheckedIndexedAccess #52318

Uh oh!

Conversation

Andarist commented Jan 19, 2023

Uh oh!

RyanCavanaugh commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

nocodb/nocodb

Last few requests

Repro Steps

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

Compiler

TSServer

Startup

Uh oh!

Andarist commented Jan 20, 2023

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fixed binding element types coming from the out of tuple bounds under `noUncheckedIndexedAccess` #52318

Fixed binding element types coming from the out of tuple bounds under `noUncheckedIndexedAccess` #52318

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading