Skip to content

Predicates on Number imply number type. #51601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mirek
Copy link

@mirek mirek commented Nov 20, 2022

Fixes #

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src/lib' or possibly our lib generator. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src/lib' or https://github.com/microsoft/TypeScript-DOM-lib-generator

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Nov 20, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 20, 2022
@fatcerberus
Copy link

fatcerberus commented Nov 21, 2022

See #39090 (comment). This change is not sound and would require #15048 as a prerequisite.

@sandersn
Copy link
Member

sandersn commented Dec 2, 2022

@mirek Can you open an issue to design this fix instead? @fatcerberus 's comment does make it sound like it's not possible without some new features in the compiler, though.
In the meantime, to help with PR housekeeping, I'm going to close this PR since the eventual solution will probably be quite a bit larger.

@sandersn sandersn closed this Dec 2, 2022
@mirek mirek deleted the implies-number branch May 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug lib update PR modifies files in the `lib` folder
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants