-
Notifications
You must be signed in to change notification settings - Fork 12.9k
feat(51000) - Flag Deprecation Plan #51424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e4ecc3f
feat(51000): add ignoreDeprecations option
a-tarasyuk 961d473
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk d8f37a0
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk 8ca255a
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk ec71ffb
use constants of versions
a-tarasyuk abb514e
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk d6e9c2e
change the ignoreDeprecations type to allow only one value - '5.0'
a-tarasyuk 7cd82f2
add tests
a-tarasyuk 5522627
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk 9ca08d7
update baseline
a-tarasyuk 8efc7de
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk 755ae6a
add typeScriptVersion to CreateProgramOptions
a-tarasyuk efea552
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk 1f5b6e8
update baseline
a-tarasyuk be592c6
change diagnostic message
a-tarasyuk 5b5f0f8
Merge branch 'main' of https://github.com/microsoft/TypeScript into f…
a-tarasyuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
tests/baselines/reference/deprecatedCompilerOptions1.errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/foo/tsconfig.json(3,19): error TS5096: Flag 'ES3' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(4,9): error TS5096: Flag 'noImplicitUseStrict' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(5,9): error TS5096: Flag 'keyofStringsOnly' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(6,9): error TS5096: Flag 'suppressExcessPropertyErrors' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(7,9): error TS5096: Flag 'suppressImplicitAnyIndexErrors' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(8,9): error TS5096: Flag 'noStrictGenericChecks' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(9,9): error TS5096: Flag 'charset' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
/foo/tsconfig.json(10,9): error TS5096: Flag 'out' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
|
||
|
||
==== /foo/tsconfig.json (8 errors) ==== | ||
{ | ||
"compilerOptions": { | ||
"target": "ES3", | ||
~~~~~ | ||
!!! error TS5096: Flag 'ES3' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"noImplicitUseStrict": true, | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5096: Flag 'noImplicitUseStrict' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"keyofStringsOnly": true, | ||
~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5096: Flag 'keyofStringsOnly' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"suppressExcessPropertyErrors": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5096: Flag 'suppressExcessPropertyErrors' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"suppressImplicitAnyIndexErrors": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5096: Flag 'suppressImplicitAnyIndexErrors' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"noStrictGenericChecks": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5096: Flag 'noStrictGenericChecks' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"charset": "utf8", | ||
~~~~~~~~~ | ||
!!! error TS5096: Flag 'charset' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
"out": "dist.js" | ||
~~~~~ | ||
!!! error TS5096: Flag 'out' is deprecated and will stop functioning in TypeScript 5.5. Specify 'ignoreDeprecations: "5.0"' to silence this error. | ||
} | ||
} | ||
|
||
==== /foo/a.ts (0 errors) ==== | ||
const a = 1; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
//// [a.ts] | ||
const a = 1; | ||
|
||
|
||
//// [dist.js] | ||
var a = 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : Symbol(a, Decl(a.ts, 0, 5)) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : 1 | ||
>1 : 1 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
//// [a.ts] | ||
const a = 1; | ||
|
||
|
||
//// [dist.js] | ||
var a = 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : Symbol(a, Decl(a.ts, 0, 5)) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : 1 | ||
>1 : 1 | ||
|
43 changes: 43 additions & 0 deletions
43
tests/baselines/reference/deprecatedCompilerOptions3.errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/foo/tsconfig.json(3,19): error TS5097: Flag 'ES3' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(4,9): error TS5097: Flag 'noImplicitUseStrict' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(5,9): error TS5097: Flag 'keyofStringsOnly' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(6,9): error TS5097: Flag 'suppressExcessPropertyErrors' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(7,9): error TS5097: Flag 'suppressImplicitAnyIndexErrors' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(8,9): error TS5097: Flag 'noStrictGenericChecks' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(9,9): error TS5097: Flag 'charset' is deprecated, please remove it from your configuration. | ||
/foo/tsconfig.json(10,9): error TS5097: Flag 'out' is deprecated, please remove it from your configuration. | ||
|
||
|
||
==== /foo/tsconfig.json (8 errors) ==== | ||
{ | ||
"compilerOptions": { | ||
"target": "ES3", | ||
~~~~~ | ||
!!! error TS5097: Flag 'ES3' is deprecated, please remove it from your configuration. | ||
"noImplicitUseStrict": true, | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5097: Flag 'noImplicitUseStrict' is deprecated, please remove it from your configuration. | ||
"keyofStringsOnly": true, | ||
~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5097: Flag 'keyofStringsOnly' is deprecated, please remove it from your configuration. | ||
"suppressExcessPropertyErrors": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5097: Flag 'suppressExcessPropertyErrors' is deprecated, please remove it from your configuration. | ||
"suppressImplicitAnyIndexErrors": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5097: Flag 'suppressImplicitAnyIndexErrors' is deprecated, please remove it from your configuration. | ||
"noStrictGenericChecks": true, | ||
~~~~~~~~~~~~~~~~~~~~~~~ | ||
!!! error TS5097: Flag 'noStrictGenericChecks' is deprecated, please remove it from your configuration. | ||
"charset": "utf8", | ||
~~~~~~~~~ | ||
!!! error TS5097: Flag 'charset' is deprecated, please remove it from your configuration. | ||
"out": "dist.js" | ||
~~~~~ | ||
!!! error TS5097: Flag 'out' is deprecated, please remove it from your configuration. | ||
} | ||
} | ||
|
||
==== /foo/a.ts (0 errors) ==== | ||
const a = 1; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
//// [a.ts] | ||
const a = 1; | ||
|
||
|
||
//// [dist.js] | ||
var a = 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : Symbol(a, Decl(a.ts, 0, 5)) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
=== /foo/a.ts === | ||
const a = 1; | ||
>a : 1 | ||
>1 : 1 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.