Skip to content

feat(49834): Suggestion: filter enum member ids from their own jsdocs #49843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #49834

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 9, 2022
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions about how much this covers.

@sandersn sandersn self-assigned this Jul 27, 2022
@sandersn sandersn requested a review from gabritto July 27, 2022 22:08
@a-tarasyuk a-tarasyuk requested a review from sandersn July 28, 2022 10:38
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One long comment; summary: fallback behaviour like class properties should be implemented in the same place that is.

@a-tarasyuk a-tarasyuk requested a review from sandersn August 2, 2022 15:53
@sandersn sandersn merged commit 19e2a31 into microsoft:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Suggestion: filter enum member ids from their own jsdocs
4 participants