Skip to content

disambiguate: 'implements' starts heritage clause vs 'implements' is … #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/compiler/parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4809,7 +4809,7 @@ namespace ts {
node.decorators = decorators;
setModifiers(node, modifiers);
parseExpected(SyntaxKind.ClassKeyword);
node.name = parseOptionalIdentifier();
node.name = parseNameOfClassDeclarationOrExpression();
node.typeParameters = parseTypeParameters();
node.heritageClauses = parseHeritageClauses(/*isClassHeritageClause*/ true);

Expand All @@ -4825,7 +4825,22 @@ namespace ts {

return finishNode(node);
}


function parseNameOfClassDeclarationOrExpression(): Identifier {
// implements is a future reserved word so
// 'class implements' might mean either
// - class expression with omitted name, 'implements' starts heritage clause
// - class with name 'implements'
// 'isImplementsClause' helps to disambiguate between these two cases
return isIdentifier() && !isImplementsClause()
? parseIdentifier()
: undefined;
}

function isImplementsClause() {
return token === SyntaxKind.ImplementsKeyword && lookAhead(nextTokenIsIdentifierOrKeyword)
}

function parseHeritageClauses(isClassHeritageClause: boolean): NodeArray<HeritageClause> {
// ClassTail[Yield,Await] : (Modified) See 14.5
// ClassHeritage[?Yield,?Await]opt { ClassBody[?Yield,?Await]opt }
Expand Down
16 changes: 16 additions & 0 deletions tests/baselines/reference/implementsInClassExpression.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//// [implementsInClassExpression.ts]
interface Foo {
doThing(): void;
}

let cls = class implements Foo {
doThing() { }
}

//// [implementsInClassExpression.js]
var cls = (function () {
function class_1() {
}
class_1.prototype.doThing = function () { };
return class_1;
})();
15 changes: 15 additions & 0 deletions tests/baselines/reference/implementsInClassExpression.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
=== tests/cases/compiler/implementsInClassExpression.ts ===
interface Foo {
>Foo : Symbol(Foo, Decl(implementsInClassExpression.ts, 0, 0))

doThing(): void;
>doThing : Symbol(doThing, Decl(implementsInClassExpression.ts, 0, 15))
}

let cls = class implements Foo {
>cls : Symbol(cls, Decl(implementsInClassExpression.ts, 4, 3))
>Foo : Symbol(Foo, Decl(implementsInClassExpression.ts, 0, 0))

doThing() { }
>doThing : Symbol((Anonymous class).doThing, Decl(implementsInClassExpression.ts, 4, 32))
}
16 changes: 16 additions & 0 deletions tests/baselines/reference/implementsInClassExpression.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/implementsInClassExpression.ts ===
interface Foo {
>Foo : Foo

doThing(): void;
>doThing : () => void
}

let cls = class implements Foo {
>cls : typeof (Anonymous class)
>class implements Foo { doThing() { }} : typeof (Anonymous class)
>Foo : Foo

doThing() { }
>doThing : () => void
}
7 changes: 7 additions & 0 deletions tests/cases/compiler/implementsInClassExpression.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
interface Foo {
doThing(): void;
}

let cls = class implements Foo {
doThing() { }
}