Skip to content

Un‑consolidate and fix WeakMap constructor overloads #41635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Nov 22, 2020

Fixes #27951 for WeakMap.
Fixes #23551 which regressed as a result of #28052 only changing the Iterable‑taking constructor overload.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 22, 2020
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@sandersn
Copy link
Member

sandersn commented Dec 1, 2020

Can you please open a new bug explaining the current problem and the history of how we got here? There's a lot of cross-referencing needed to understand what is wrong.

@sandersn sandersn self-assigned this Dec 1, 2020
@sandersn
Copy link
Member

Is this still needed? The linked bugs are both closed.

@ExE-Boss
Copy link
Contributor Author

Note that #23551 should be re‑opened, as it’s occurring again as a result of #28052 only changing the Iterable overload.

@sandersn
Copy link
Member

I'm going to close this to reduce the number of old open PRs. @ExE-Boss, if you want to keep working on it, please create a new bug based on #23551 explaining why it's still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extending Map with wrong number of type arguments shows no error Can't extend WeakMap in type-checked JS files
3 participants