Remove object literal freshness in control flow based array types

[ahejlsberg]

Fixes #39470.

[DanielRosenwasser]

Can't imagine this breaks anything but

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 56b0a51. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 56b0a51. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 56b0a51. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 56b0a51. You can monitor the build here.

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39518

Metric	master	39518	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	343,841k (± 0.02%)	343,449k (± 0.03%)	-392k (- 0.11%)	343,223k	343,619k
Parse Time	2.01s (± 0.59%)	2.01s (± 0.64%)	+0.00s (+ 0.20%)	1.97s	2.03s
Bind Time	0.81s (± 0.61%)	0.82s (± 0.58%)	+0.00s (+ 0.37%)	0.81s	0.83s
Check Time	4.74s (± 0.59%)	4.74s (± 0.56%)	-0.00s (- 0.04%)	4.66s	4.78s
Emit Time	5.17s (± 0.55%)	5.18s (± 0.74%)	+0.01s (+ 0.23%)	5.13s	5.31s
Total Time	12.73s (± 0.37%)	12.75s (± 0.42%)	+0.02s (+ 0.13%)	12.65s	12.92s
Monaco - node (v10.16.3, x64)
Memory used	339,123k (± 0.03%)	339,146k (± 0.02%)	+24k (+ 0.01%)	338,972k	339,304k
Parse Time	1.58s (± 0.43%)	1.58s (± 0.47%)	+0.00s (+ 0.13%)	1.56s	1.59s
Bind Time	0.71s (± 0.73%)	0.71s (± 0.73%)	0.00s ( 0.00%)	0.70s	0.72s
Check Time	4.90s (± 0.59%)	4.91s (± 0.53%)	+0.01s (+ 0.14%)	4.85s	4.97s
Emit Time	2.74s (± 0.88%)	2.74s (± 0.61%)	+0.00s (+ 0.11%)	2.70s	2.79s
Total Time	9.92s (± 0.41%)	9.94s (± 0.37%)	+0.01s (+ 0.13%)	9.86s	10.03s
TFS - node (v10.16.3, x64)
Memory used	302,042k (± 0.02%)	302,104k (± 0.02%)	+62k (+ 0.02%)	301,887k	302,240k
Parse Time	1.21s (± 0.54%)	1.21s (± 0.74%)	-0.00s (- 0.17%)	1.18s	1.22s
Bind Time	0.67s (± 0.71%)	0.67s (± 0.70%)	+0.00s (+ 0.45%)	0.66s	0.68s
Check Time	4.40s (± 0.27%)	4.40s (± 0.40%)	-0.00s (- 0.07%)	4.36s	4.44s
Emit Time	2.91s (± 0.89%)	2.89s (± 0.80%)	-0.03s (- 0.89%)	2.84s	2.94s
Total Time	9.19s (± 0.35%)	9.16s (± 0.50%)	-0.03s (- 0.27%)	9.07s	9.25s
material-ui - node (v10.16.3, x64)
Memory used	459,409k (± 0.02%)	459,087k (± 0.02%)	-322k (- 0.07%)	458,897k	459,339k
Parse Time	2.04s (± 0.37%)	2.04s (± 0.46%)	+0.01s (+ 0.34%)	2.03s	2.06s
Bind Time	0.65s (± 1.26%)	0.64s (± 1.55%)	-0.00s (- 0.62%)	0.63s	0.67s
Check Time	12.90s (± 0.88%)	12.90s (± 0.66%)	+0.00s (+ 0.02%)	12.71s	13.06s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.59s (± 0.73%)	15.59s (± 0.56%)	+0.01s (+ 0.04%)	15.41s	15.75s
Angular - node (v12.1.0, x64)
Memory used	321,156k (± 0.02%)	320,566k (± 0.08%)	-590k (- 0.18%)	319,508k	320,749k
Parse Time	1.99s (± 0.60%)	1.99s (± 0.65%)	-0.00s (- 0.15%)	1.96s	2.01s
Bind Time	0.80s (± 0.37%)	0.80s (± 0.42%)	+0.01s (+ 0.63%)	0.80s	0.81s
Check Time	4.63s (± 0.50%)	4.64s (± 0.62%)	+0.01s (+ 0.26%)	4.58s	4.71s
Emit Time	5.37s (± 0.75%)	5.35s (± 1.00%)	-0.02s (- 0.41%)	5.28s	5.53s
Total Time	12.79s (± 0.44%)	12.78s (± 0.60%)	-0.01s (- 0.05%)	12.66s	13.05s
Monaco - node (v12.1.0, x64)
Memory used	321,569k (± 0.02%)	321,568k (± 0.02%)	-1k (- 0.00%)	321,454k	321,756k
Parse Time	1.55s (± 0.76%)	1.55s (± 0.80%)	+0.00s (+ 0.06%)	1.51s	1.57s
Bind Time	0.69s (± 0.43%)	0.69s (± 0.81%)	0.00s ( 0.00%)	0.68s	0.70s
Check Time	4.65s (± 0.44%)	4.68s (± 0.44%)	+0.03s (+ 0.56%)	4.64s	4.74s
Emit Time	2.80s (± 0.63%)	2.80s (± 0.59%)	+0.01s (+ 0.29%)	2.77s	2.84s
Total Time	9.69s (± 0.36%)	9.73s (± 0.34%)	+0.04s (+ 0.39%)	9.66s	9.80s
TFS - node (v12.1.0, x64)
Memory used	286,558k (± 0.03%)	286,534k (± 0.02%)	-25k (- 0.01%)	286,437k	286,664k
Parse Time	1.23s (± 0.62%)	1.23s (± 0.57%)	+0.01s (+ 0.49%)	1.22s	1.25s
Bind Time	0.64s (± 0.90%)	0.64s (± 0.91%)	-0.01s (- 0.93%)	0.63s	0.65s
Check Time	4.30s (± 0.36%)	4.28s (± 0.44%)	-0.03s (- 0.63%)	4.23s	4.32s
Emit Time	2.92s (± 0.99%)	2.91s (± 0.66%)	-0.01s (- 0.27%)	2.87s	2.96s
Total Time	9.10s (± 0.39%)	9.06s (± 0.32%)	-0.04s (- 0.42%)	9.02s	9.14s
material-ui - node (v12.1.0, x64)
Memory used	437,850k (± 0.01%)	437,553k (± 0.02%)	-297k (- 0.07%)	437,421k	437,724k
Parse Time	2.02s (± 0.53%)	2.02s (± 0.55%)	+0.00s (+ 0.10%)	2.00s	2.05s
Bind Time	0.63s (± 0.79%)	0.62s (± 1.00%)	-0.01s (- 1.12%)	0.60s	0.63s
Check Time	11.56s (± 1.17%)	11.57s (± 0.76%)	+0.01s (+ 0.05%)	11.42s	11.76s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	14.21s (± 0.96%)	14.21s (± 0.66%)	+0.00s (+ 0.01%)	14.04s	14.41s
Angular - node (v8.9.0, x64)
Memory used	340,444k (± 0.02%)	340,099k (± 0.01%)	-346k (- 0.10%)	339,954k	340,192k
Parse Time	2.53s (± 0.29%)	2.54s (± 0.63%)	+0.01s (+ 0.32%)	2.52s	2.58s
Bind Time	0.85s (± 0.68%)	0.85s (± 0.73%)	-0.00s (- 0.12%)	0.84s	0.86s
Check Time	5.35s (± 0.59%)	5.35s (± 0.75%)	-0.00s (- 0.06%)	5.26s	5.46s
Emit Time	5.91s (± 1.41%)	5.90s (± 0.81%)	-0.01s (- 0.10%)	5.79s	6.06s
Total Time	14.65s (± 0.65%)	14.64s (± 0.44%)	-0.01s (- 0.05%)	14.54s	14.82s
Monaco - node (v8.9.0, x64)
Memory used	340,478k (± 0.02%)	340,502k (± 0.01%)	+25k (+ 0.01%)	340,422k	340,575k
Parse Time	1.87s (± 0.47%)	1.87s (± 0.36%)	-0.00s (- 0.16%)	1.85s	1.88s
Bind Time	0.88s (± 0.56%)	0.88s (± 0.51%)	-0.00s (- 0.23%)	0.87s	0.89s
Check Time	5.41s (± 0.43%)	5.41s (± 0.54%)	-0.00s (- 0.07%)	5.37s	5.49s
Emit Time	3.23s (± 0.35%)	3.22s (± 0.40%)	-0.01s (- 0.25%)	3.20s	3.26s
Total Time	11.39s (± 0.18%)	11.38s (± 0.33%)	-0.02s (- 0.14%)	11.32s	11.47s
TFS - node (v8.9.0, x64)
Memory used	303,826k (± 0.02%)	303,847k (± 0.02%)	+20k (+ 0.01%)	303,759k	303,952k
Parse Time	1.54s (± 0.53%)	1.55s (± 0.62%)	+0.01s (+ 0.39%)	1.53s	1.58s
Bind Time	0.67s (± 0.77%)	0.67s (± 0.66%)	+0.00s (+ 0.15%)	0.66s	0.68s
Check Time	5.08s (± 1.89%)	5.07s (± 1.61%)	-0.01s (- 0.24%)	4.89s	5.21s
Emit Time	3.01s (± 2.90%)	3.00s (± 2.77%)	-0.01s (- 0.27%)	2.89s	3.18s
Total Time	10.30s (± 0.42%)	10.29s (± 0.37%)	-0.01s (- 0.09%)	10.19s	10.38s
material-ui - node (v8.9.0, x64)
Memory used	463,657k (± 0.01%)	463,388k (± 0.01%)	-269k (- 0.06%)	463,297k	463,483k
Parse Time	2.39s (± 0.34%)	2.40s (± 0.68%)	+0.01s (+ 0.25%)	2.35s	2.43s
Bind Time	0.77s (± 1.16%)	0.77s (± 1.16%)	0.00s ( 0.00%)	0.75s	0.79s
Check Time	17.17s (± 0.85%)	17.23s (± 0.96%)	+0.06s (+ 0.36%)	16.88s	17.48s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	20.33s (± 0.75%)	20.40s (± 0.82%)	+0.07s (+ 0.33%)	20.03s	20.66s
Angular - node (v8.9.0, x86)
Memory used	195,310k (± 0.02%)	195,135k (± 0.02%)	-175k (- 0.09%)	195,044k	195,217k
Parse Time	2.46s (± 0.77%)	2.45s (± 0.71%)	-0.01s (- 0.37%)	2.42s	2.50s
Bind Time	0.99s (± 0.82%)	0.98s (± 0.91%)	-0.01s (- 0.61%)	0.97s	1.00s
Check Time	4.82s (± 0.43%)	4.85s (± 0.98%)	+0.03s (+ 0.58%)	4.73s	4.96s
Emit Time	5.90s (± 1.39%)	5.87s (± 1.18%)	-0.03s (- 0.59%)	5.70s	6.00s
Total Time	14.18s (± 0.64%)	14.16s (± 0.81%)	-0.02s (- 0.16%)	13.84s	14.33s
Monaco - node (v8.9.0, x86)
Memory used	193,495k (± 0.02%)	193,487k (± 0.02%)	-9k (- 0.00%)	193,427k	193,592k
Parse Time	1.92s (± 1.31%)	1.90s (± 0.62%)	-0.01s (- 0.68%)	1.88s	1.93s
Bind Time	0.70s (± 0.64%)	0.70s (± 0.74%)	+0.00s (+ 0.43%)	0.69s	0.71s
Check Time	5.49s (± 0.55%)	5.48s (± 1.15%)	-0.01s (- 0.22%)	5.24s	5.56s
Emit Time	2.67s (± 0.58%)	2.70s (± 2.80%)	+0.03s (+ 0.97%)	2.64s	3.00s
Total Time	10.78s (± 0.37%)	10.78s (± 0.37%)	+0.00s (+ 0.02%)	10.68s	10.86s
TFS - node (v8.9.0, x86)
Memory used	173,755k (± 0.02%)	173,785k (± 0.04%)	+30k (+ 0.02%)	173,713k	174,033k
Parse Time	1.59s (± 1.39%)	1.59s (± 1.14%)	+0.01s (+ 0.38%)	1.56s	1.65s
Bind Time	0.64s (± 0.90%)	0.64s (± 1.01%)	+0.00s (+ 0.31%)	0.63s	0.66s
Check Time	4.68s (± 0.35%)	4.71s (± 0.62%)	+0.02s (+ 0.53%)	4.63s	4.78s
Emit Time	2.79s (± 1.03%)	2.80s (± 1.07%)	+0.01s (+ 0.43%)	2.74s	2.89s
Total Time	9.69s (± 0.47%)	9.74s (± 0.58%)	+0.05s (+ 0.47%)	9.62s	9.89s
material-ui - node (v8.9.0, x86)
Memory used	262,548k (± 0.02%)	262,400k (± 0.02%)	-149k (- 0.06%)	262,302k	262,508k
Parse Time	2.45s (± 0.70%)	2.46s (± 0.84%)	+0.01s (+ 0.49%)	2.41s	2.52s
Bind Time	0.67s (± 2.50%)	0.66s (± 0.79%)	-0.01s (- 1.49%)	0.65s	0.68s
Check Time	15.66s (± 0.82%)	15.59s (± 0.45%)	-0.07s (- 0.47%)	15.41s	15.70s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	18.78s (± 0.77%)	18.71s (± 0.43%)	-0.07s (- 0.39%)	18.49s	18.84s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	1 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)
• material-ui - node (v10.16.3, x64)
• material-ui - node (v12.1.0, x64)
• material-ui - node (v8.9.0, x64)
• material-ui - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	39518	10
Baseline	master	10