Skip to content

Exempt ambient private properties from noImplicitAny #36640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2020
Merged

Exempt ambient private properties from noImplicitAny #36640

merged 1 commit into from
Feb 14, 2020

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Feb 5, 2020

Fixes: #36630

@DanielRosenwasser
Copy link
Member

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address you're using for your commits, or rebase and amend your commits to fix the author name and email.

If you don't care about any of this stuff, I can always just pull in the changes.

@ajafff ajafff force-pushed the ambient-private-implicit-any branch from 5ee2611 to 7e44294 Compare February 5, 2020 20:36
@ajafff
Copy link
Contributor Author

ajafff commented Feb 5, 2020

Setting up a new dev machine is hard ... I fixed the email in the commit. It's now correctly linked to my account. Thank you for the heads up.

@DanielRosenwasser
Copy link
Member

This will need to be cherry-picked into release-3.8

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.8 and LKG

1 similar comment
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.8 and LKG

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 14, 2020
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.8

@DanielRosenwasser DanielRosenwasser merged commit 9b518c8 into microsoft:master Feb 14, 2020
DanielRosenwasser pushed a commit that referenced this pull request Feb 14, 2020
@ajafff @DanielRosenwasser
Exempt ambient private properties from noImplicitAny (#36640)
051eee0
@sandersn sandersn mentioned this pull request Feb 26, 2020
Closed
@dnalborczyk dnalborczyk mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of private fields with noImplicitAny triggers TS7008
4 participants
@ajafff @DanielRosenwasser @sheetalkamat @sandersn