Skip to content

Fix #31319 : Narrow unit-unit inequality tests using comparability #33071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jack-williams
Copy link
Collaborator

Fixes #31319

@jack-williams jack-williams force-pushed the 31319-literal-equality-narrowing branch from e98a0f6 to ccdf33d Compare August 24, 2019 17:36
@jack-williams
Copy link
Collaborator Author

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 24, 2019

Heya @jack-williams, I've started to run the parallelized community code test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 24, 2019

Heya @jack-williams, I've started to run the parallelized Definitely Typed test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 24, 2019

Heya @jack-williams, I've started to run the extended test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@jack-williams
Copy link
Collaborator Author

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2019

Heya @jack-williams, I've started to run the parallelized Definitely Typed test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2019

Heya @jack-williams, I've started to run the extended test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2019

Heya @jack-williams, I've started to run the parallelized community code test suite on this PR at ccdf33d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
@sandersn sandersn requested a review from weswigham March 10, 2020 20:33
@weswigham
Copy link
Member

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 30, 2020

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 967bd66. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 30, 2020

Heya @weswigham, I've started to run the extended test suite on this PR at 967bd66. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 30, 2020

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 967bd66. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member

All the tests look good post-merge, so I'm merging this~

@weswigham weswigham merged commit 4c440e5 into microsoft:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

type guard about const enum and string
4 participants