Skip to content

Ignore unknown files to search from in document highlights #32791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

sheetalkamat
Copy link
Member

@amcasey this fixes the issue you brought up when two files don't belong to same project during your scenario we were getting exception earlier.

@sheetalkamat sheetalkamat merged commit 825d8bb into master Aug 9, 2019
@sheetalkamat sheetalkamat deleted the documentHighlightsFilesToSearch branch August 9, 2019 22:34
@amcasey
Copy link
Member

amcasey commented Aug 9, 2019

@sheetalkamat Thanks! Would it be helpful to have a list of the commands affected by this error?

@sheetalkamat
Copy link
Member Author

DocumentHighlights, DocumentHighlights-Full and Occurrences

@amcasey
Copy link
Member

amcasey commented Aug 12, 2019

Sorry, my question wasn't very clear. I believe there are some other commands that might be affected by related issues. In 3.5.2, we were seeing this error for:

completionEntryDetails
completionInfo
completions-full
definition
definition-full
definitionAndBoundSpan
definitionAndBoundSpan-full
documentHighlights
documentHighlights-full
encodedSemanticClassifications-full
getApplicableRefactors
getCodeFixes
getCodeFixes-full
implementation
implementation-full
organizeImports
organizeImports-full
quickinfo
quickinfo-full
references
rename
semanticDiagnosticsSync
signatureHelp
suggestionDiagnosticsSync
syntacticDiagnosticsSync
typeDefinition

@sheetalkamat
Copy link
Member Author

@amcasey that seems more like something else might have gone wrong before this .. this fix was specific to repro you sent me and i had looked up if there exists anything similar throughout our code base. Other commands can go bad with bad project state or something following early exception ?

@amcasey
Copy link
Member

amcasey commented Aug 12, 2019

@sheetalkamat Unfortunately, I don't have additional information. If I find a repro for one of the other commands, I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants