Skip to content

Add try priors as finally lock label andecedents rather than pre finally label antecedents #29790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Feb 7, 2019

Fixes #29684

Rather than

                (1-pre-try-flow) <--(inner try flows) <-- (2-post-try-flow)
                 ^                           ^^^^              ^
                 |*****(3-pre-finally-label) ------------------|
                               ^
                               |-- ... <-- (4-post-finally-label) <--- (5)

now we

                (1-pre-try-flow) <--(inner try flows) <-- (2-post-try-flow)
                 ^                           ^^^^              ^
                 |-----(pre-finally-flow)-------|              |
                            ^                                  |
                            |*****(3-pre-finally-label)--------|
                                       ^
                                       |-- ... <-- (4-post-finally-label) <--- (5)

so all the inner try flows are behind the lock.

@weswigham weswigham merged commit 8e5dcfb into microsoft:master Feb 7, 2019
@weswigham weswigham deleted the try-finally-binding-lock branch February 7, 2019 00:59
weswigham added a commit to weswigham/TypeScript that referenced this pull request Feb 13, 2019
@DanielRosenwasser
Copy link
Member

It'd also be awesome if you could add the comment in this PR to the code ;)

weswigham added a commit that referenced this pull request Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants