-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Enhancements to SourceMap decoder from tsserver #28886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad or remove projects independently
Map Info and sources is not ideal and need to revisited since we need to update mapper and projects correctly // TODO: lifetime of source project and declaration map
…or map file TODO: add tests
… source file, map file etc
weswigham
reviewed
Dec 7, 2018
weswigham
reviewed
Dec 7, 2018
Please review the PR so we can get this in soon. |
weswigham
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should get @rbuckton to look over the sourcemap decoder changes, too.
Ping @rbuckton |
Merging this. Will handle any feedback that @rbuckton provides in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current design for creation of source map decoder per project isn't efficient for tsserver. It could be referencing multiple projects for same declaration source map's and each project creates its own source map decoder. Apart from that each source map decoder reads for files and caches them in the decoder for files that aren't present in the program corresponding to the project.
With this approach, it adds a method on
LanguageServiceHost
asgetDocumentPositionMapper
: When provided it uses this method to get the document position mapper instead of creating one on its own.getDocumentPositionMapper
: When provided it gets theSourceFileLike
subset toSourceFile
that offers text or optionally methods to map line character to absolute position and other way around. (This helps with us just using snapshots when created to transform these instead of recomputing line starts and doing custom operation.With this new API, tsserver project now implements these apis to create and cache the Document position mapper on the declaration file's script info. This is maintained till there is change in map file/declaration file. Apart from document position mapper, it maintains the list of source script infos associated with it to update the projects from whenever map file changes.
Apart from this change, it also fixes few existing issues found during additional test writing: