Skip to content

Use originalFileName (fileName of input project reference file) to resolve module/typereferences/reference paths in it instead of output decl file path #27172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2018
Merged

Use originalFileName (fileName of input project reference file) to resolve module/typereferences/reference paths in it instead of output decl file path #27172

merged 2 commits into from
Sep 18, 2018

Conversation

sheetalkamat
Copy link
Member

Fixes #26036

@sheetalkamat
Add traceResolution option to build options
b6d9084
@sheetalkamat
Use originalFileName (fileName of input project reference file) to re…
d51b8d9 
…solve module/typereferences/reference paths in it instead of output decl file path

This also ensures that originalFileName, resolvedPath are set correctly even when we are reusing program structure
Fixes #26036
@sheetalkamat
Copy link
Member Author

The test only failed on node10 because of setup and unrelated to this PR

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.1 milestone Sep 18, 2018
@sheetalkamat sheetalkamat merged commit 865b3e7 into master Sep 18, 2018
@sheetalkamat sheetalkamat deleted the moduleResolutionWithOutDir branch September 18, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TypeScript 3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @RyanCavanaugh